8000 Parsing HTML to Markdown AST by ginnyTheCat · Pull Request #847 · cinnyapp/cinny · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parsing HTML to Markdown AST #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 16, 2022
Merged

Parsing HTML to Markdown AST #847

merged 14 commits into from
Sep 16, 2022

Conversation

ginnyTheCat
Copy link
Contributor
@ginnyTheCat ginnyTheCat commented Sep 14, 2022 •
edited by github-actions bot
Loading

Description

This parses the formatted_body (if available) into the markdown ast to then render it as plaintext. This allows spoilers to not be visible in notifications (now showing up as <spoiler>), while still showing during edits as ||spoiler|| and in the future as [spoiler](mxc://somewhere) in the body shown in plaintext clients.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://847--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ginnyTheCat ginnyTheCat marked this pull request as ready for review September 14, 2022 22:21
ajbura
ajbura reviewed Sep 16, 2022
View reviewed changes
ajbura
ajbura approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member
@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you!

@ajbura ajbura merged commit a8f374d into cinnyapp:dev Sep 16, 2022
@ginnyTheCat ginnyTheCat deleted the markdown-html branch September 16, 2022 15:53
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@ginnyTheCat @NovaAndrom3da
Parsing HTML to Markdown AST (cinnyapp#847)
89bee86 
* Force mentions to have a space after the #

* Use types for rendering

* Parse HTML

* Add code block support

* Add table support

* Allow starting heading without a space

* Escape relevant plaintext areas

* Resolve many crashes

* Use better matrix id regex

* Don't match . after id

* Don't parse mentions as links

* Add emote support

* Only emit HTML link if necessary

* Implement review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginnyTheCat @ajbura
0