8000 Fix parsing encoded matrix.to URL by chuangzhu · Pull Request #660 · cinnyapp/cinny · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix parsing encoded matrix.to URL #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix parsing encoded matrix.to URL #660

merged 1 commit into from
Jul 4, 2022

Conversation

chuangzhu
Copy link
Contributor
@chuangzhu chuangzhu commented Jul 1, 2022 •
edited by github-actions bot
Loading

Description

Fix parsing percent encoded mention link, e.g. https://matrix.to/#/%40alice%3Aexample.org.

From https://spec.matrix.org/v1.3/appendices/#matrixto-navigation:

The components of the matrix.to URI ( and ) are to be percent-encoded as per RFC 3986.

Historically, clients have not produced URIs which are fully encoded. Clients should try to interpret these cases to the best of their ability. For example, an unencoded room alias should still work within the client if possible

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://62be974c1173561b66ffc7ee--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@chuangzhu
Fix parsing encoded matrix.to URL
79879b2 
From https://spec.matrix.org/v1.3/appendices/#matrixto-navigation:

	The components of the matrix.to URI (<identifier> and <extra parameter>) are to be percent-encoded as per RFC 3986.

	Historically, clients have not produced URIs which are fully encoded. Clients should try to interpret these cases to the best of their ability. For example, an unencoded room alias should still work within the client if possible
@ajbura
Copy link
Member
ajbura commented Jul 4, 2022

Thank you.

@ajbura ajbura merged commit a6f21b6 into cinnyapp:dev Jul 4, 2022
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@chuangzhu @NovaAndrom3da
Fix parsing encoded matrix.to URL (cinnyapp#660)
d9e1234 
From https://spec.matrix.org/v1.3/appendices/#matrixto-navigation:

	The components of the matrix.to URI (<identifier> and <extra parameter>) are to be percent-encoded as per RFC 3986.

	Historically, clients have not produced URIs which are fully encoded. Clients should try to interpret these cases to the best of their ability. For example, an unencoded room alias should still work within the client if possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuangzhu @ajbura
0