Change: Make "View Source" a developer tool
#2368
Merged
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great feature to be added, since this feature has been existing on element/schildichat for a long time now. |
|
Preview: https://2368--pr-cinny.netlify.app |
|
Sorry for re-requesting, but the workflow wants another approval |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Viewing the raw JSON data for messages is rarely done in normal use by non-developers. Therefore I suggest that enabling this button's visibility is controlled by the "Developer Tools" switch in "Settings">"Developer Tools". This de-clutters the context menu for regular users.
This PR uses the "Developer Tools" switch to control the "View Source" button's visibility in context menus for messages and events.
Fixes #2352
Type of change
Checklist: