8000 Fix room header members icon not filled when enabled by GimleLarpes · Pull Request #2367 · cinnyapp/cinny · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix room header members icon not filled when enabled #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix room header members icon not filled when enabled #2367

wants to merge 4 commits into from

Conversation

GimleLarpes
Copy link
Contributor
@GimleLarpes GimleLarpes commented Jun 19, 2025 •
edited
Loading

Description

The current behaviour of the "Members" button in room headers is incorrect, as it is not filled when the members drawer is open.

This PR makes it so that the "Members" button is filled when enabled, as is the correct behaviour according to [1997kB].

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [o] New feature (non-breaking change which adds functionality)
  • [o] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [o] This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@GimleLarpes GimleLarpes mentioned this pull request Jun 21, 2025
Open
9 tasks
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 27, 2025 •
edited
Loading

Preview: https://2367--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura
Copy link
Member
ajbura commented Jun 27, 2025

The "Members" icon is not filled on click because the functionality it toggle is a view that is detached from current toggle unlike something like "Pinned Messages" (where solid icon show open state prominently). It act as preference toggle to view/hide the other side view and choice of keeping it open can't be show as prominent choice.

@GimleLarpes
Copy link
Contributor Author
GimleLarpes commented Jun 28, 2025 •
edited
Loading

I see, so the Members icon should be permanently non-filled. Would the same apply to the "Chat" button in #2335 ? (see image)
image

@ajbura
Copy link
Member
ajbura commented Jun 28, 2025

I see, so the Members icon should be permanently non-filled. Would the same apply to the "Chat" button in #2335 ?

Well most likely yes, if the chat view will open as sidepanel but as in above screenshot the chatview appears to be under room header occupying the main area of callview... it a bit challenging to know how they are approaching the feature

@GimleLarpes
Copy link
Contributor Author

Got it, I'll close this PR now.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GimleLarpes @ajbura
0