Add bidi support #139
Closed
Add bidi support #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this style Cinny is compatible with both LTR and RTL texts.
|
Cinny already has support for RTL languages, it's just that there's no button to enable it. So adding bidi text support is kind of pointless and also break the RTL. See the comparison below:
|
|
Beautiful! The important thing is that style. Please add this to both LTR and RTL style: unicode-bidi: plaintext;
text-align: initial;Thnaks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Curentlly Cinny is not supporting RTL texts. With this style Cinny become compatible with both LTR and RTL texts.
I check it using
inspecton my browser, becaus i can't build Cinny on my system.Type of change