8000 Images do not render thumbnails in timeline if missing some data · Issue #738 · cinnyapp/cinny · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Images do not render thumbnails in timeline if missing some data #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamkray opened this issue Aug 9, 2022 · 4 comments
Closed

Images do not render thumbnails in timeline if missing some data #738

williamkray opened this issue Aug 9, 2022 · 4 comments

Comments

8000
@williamkray
Copy link

Describe the bug

I use a Giphy maubot plugin which fetches an image from Giphy.com and uploads the image to the room. In element, these files generate thumbnails just fine and are viewable in the timeline.

In Cinny, these images look like an unrecognized file upload with no thumbnail.

If I manually download the file and re-upload it to Cinny, it renders fine and includes additional image data in the message source. Cinny appears to be depending on this additional data in order to render the thumbnail.

Screenshots and message source included here.

image
here you see that the giphybot has uploaded the file, but it does not render a thumbnail in the chat. the message source is as follows:

{
  "type": "m.room.message",
  "sender": "@giphy:mssj.me",
  "content": {
    "msgtype": "m.image",
    "body": "something.gif",
    "url": "mxc://mssj.me/13eabfbb9c56b9d34b50bd4707c8d07a1f1aad5e",
    "info": {
      "mimetype": "image/gif",
      "h": "357",
      "w": "360"
    }
  },
  "origin_server_ts": 1660075708630,
  "unsigned": {
    "age": 84
  },
  "event_id": "$Li__PcQ_potscI6Dky-uBw3rJxssPls1xhbZsL07qGc",
  "room_id": "!wgqLEFKEaItGQxtRTp:mssj.me"
}

Uploading the same image results in an animated thumbnail:
image
with the following message source:

{
  "type": "m.room.message",
  "sender": "@william:mssj.me",
  "content": {
    "info": {
      "mimetype": "image/gif",
      "size": 3831901,
      "w": 360,
      "h": 357,
      "xyz.amorgan.blurhash": "UKB5$~DGugaPx[yqtktmpJbctSkVt%a7Roof"
    },
    "msgtype": "m.image",
    "body": "something.gif",
    "url": "mxc://mssj.me/0c79a3957be5085059b8f6c0e5c41fef3b0fe3f6"
  },
  "origin_server_ts": 1660076008594,
  "unsigned": {
    "age": 65,
    "transaction_id": "m1660076007636.102"
  },
  "event_id": "$YjadYSKv_eBdz00hn1Lpy2Hq3dlJfsVy224gA8RT7Kw",
  "room_id": "!wgqLEFKEaItGQxtRTp:mssj.me"
}

this same exchange is rendered correctly in element-web:
image

Reproduction

  1. use maubot plugins for Giphy or auto-responder, configure them to upload images as reactions
  2. trigger the maubot instances to send an image

or, alternatively, use a client that sends similar message source to the above posted message, or send a custom event that matches the same structure.

Expected behavior

the image should be uploaded and sent, and a thumbnail should render (this behavior is expressed in element-web/desktop)

Platform and versions

1. OS: Arch Linux
2. Browser: Firefox 103.0.1
3. Cinny Version: 2.1.1
4. Matrix homeserver: jobmachine.org and mssj.me

Additional context

No response
@williamkray williamkray changed the title Images do not render thumbnails in timeline if missing Images do not render thumbnails in timeline if missing some data Aug 9, 2022
@williamkray
Copy link
Author

i've tried adding the size field to the message source as uploaded by the giphybot, and it does not seem to impact the thumbnail rendering, so it must be something else that is missing from the message data.

@kfiven
Copy link
Collaborator
kfiven commented Aug 10, 2022 
"h": "357",
"w": "360"

should be integers per spec https://spec.matrix.org/v1.3/client-server-api/#mimage but bot is sending them as string. @williamkray

@williamkray
Copy link
Author

wow i'm a dumdum. fixing the bot to send the data as an int did indeed resolve the issue. while the behavior is different than the looser handling of element, since you pointed out the spec i can't realistically ask to keep this open.

@williamkray
Copy link
Author
williamkray commented Aug 10, 2022 •
edited
Loading

actually, i'd like to re-open this... the thumbnails are not rendered if there is no dimensions included either, and the spec does not say that the dimensions or filesize are required parameters. so this is still actually valid in my opinion.

for example, this message source is totally valid according to the spec:

{
  "content": {
    "msgtype": "m.image",
    "body": "to_be_fair.gif",
    "url": "mxc://jobmachine.org/lnHTATixzDaSKlbqVbycoImb",
    "info": {
      "mimetype": "image/gif"
    }
  },
  "origin_server_ts": 1660150043142,
  "sender": "@cog:jobmachine.org",
  "type": "m.room.message",
  "unsigned": {},
  "event_id": "$trtBQHtzYas6Gl0JDZH75VqKKKamlsdKp_wueDAoQgM",
  "room_id": "!asUvXyQSkofLJzSEqe:mssj.me"
}

but does not render a thumbnail image in the chat.

sorry for flip-flopping all over the place here.

@williamkray williamkray reopened this Aug 10, 2022
ajbura added a commit that referenced this issue Aug 11, 2022
@ajbura
Fix image not loading without h/w data (#738)
820d080
@ajbura ajbura closed this as completed Aug 11, 2022
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this issue Nov 23, 2023
@ajbura @NovaAndrom3da
Fix image not loading without h/w data (cinnyapp#738)
f094256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@williamkray @ajbura @kfiven
0