[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete duplicate filters with different priority #36176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Delete duplicate filters with different priority #36176

wants to merge 1 commit into from

Conversation

tamilmani1989
Copy link
Contributor
@tamilmani1989 tamilmani1989 commented Nov 26, 2024 •
edited
Loading

The fix is to check if duplicate filter attached to same interface with same filter name but different priority and removes the old filter.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #36172

@tamilmani1989
fix: Delete duplicate filters with different priority
7ad5a8c 
The fix is to check if duplicate filter attached to same interface with same filter but different priority and removes the old filter.

Signed-off-by: Tamilmani <tamanoha@microsoft.com>
@tamilmani1989 tamilmani1989 requested a review from a team as a code owner November 26, 2024 04:02
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 26, 2024
@joestringer joestringer added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Nov 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-mo ti-mo Awaiting requested review from ti-mo ti-mo is a code owner automatically assigned from cilium/loader

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connectivity impact after changing bpf filter priority
2 participants
@tamilmani1989 @joestringer