8000 pkg/redirectpolicy: Add missing namespace check in pod update handler by aditighag · Pull Request #19193 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pkg/redirectpolicy: Add missing namespace check in pod update handler #19193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

pkg/redirectpolicy: Add missing namespace check in pod update handler #19193

merged 1 commit into from
Mar 28, 2022

Conversation

aditighag
Copy link
Member
@aditighag aditighag commented Mar 18, 2022 •
edited
Loading

pkg/redirectpolicy: Add missing namespace check

Local Redirect Policy (LRP) namespace needs to match
with the backend pods selected by the LRP.

This check was missing in the case where backend
pods are deployed after an LRP that selects them
was applied.

Reported-By: Joe Stringer joe@covalent.io

Release note

Fix a bug where a backend pod can be selected by a local redirect policy deployed in a different namespace if the local redirect policy was deployed first.

@aditighag aditighag requested review from joestringer, a team and borkmann March 18, 2022 19:15
@maintainer-s-little-helper
Copy link

Commit eb71afb9c3caa488563b96de9eceb5281e1d545a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 18, 2022
@aditighag aditighag force-pushed the pr/aditighag/lrp-fix-namespace-check branch from eb71afb to af85f46 Compare March 18, 2022 19:57
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 18, 2022
@aditighag aditighag added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Mar 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2022
@aditighag
Copy link
Member Author

/test-only --focus="K8sLRPTests" --kernel_version=net-next

@aditighag aditighag force-pushed the pr/aditighag/lrp-fix-namespace-check branch from af85f46 to 03dd99e Compare March 18, 2022 20:05
@aditighag
Copy link
Member Author
aditighag commented Mar 18, 2022 •
edited
Loading

/test-only --focus="K8sLRPTests" --kernel_version=net-next

Edit : Passed - https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/425/.

@aditighag
pkg/redirectpolicy, docs: Add missing namespace check
0ad534a 
Local Redirect Policy (LRP) namespace needs to match
with the backend pods selected by the LRP.

This check was missing in the case where backend
pods are deployed after an LRP that selects them
was applied.

Added unit tests.

Reported-by: Joe Stringer <joe@covalent.io>
Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/lrp-fix-namespace-check branch from 03dd99e to 0ad534a Compare March 18, 2022 22:27
@aditighag aditighag requested a review from a team as a code owner March 18, 2022 22:27
@aditighag
Copy link
Member Author

/test-only --focus="K8sLRPTests" --kernel_version=net-next

@aditighag
Copy link
Member Author

Latest commits only include a documentation change.

ldelossa
ldelossa approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor
@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 👍

@joestringer joestringer merged commit 2efbdd6 into cilium:master Mar 28, 2022
@qmonnet qmonnet mentioned this pull request Mar 29, 2022
Merged
@qmonnet qmonnet mentioned this pull request Mar 29, 2022
Merged
10 tasks
@qmonnet qmonnet mentioned this pull request Mar 30, 2022
Merged
18 tasks
@pchaigno pchaigno added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Apr 4, 2022
This was referenced Apr 15, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@ldelossa ldelossa ldelossa approved these changes

@borkmann borkmann Awaiting requested review from borkmann

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aditighag @joestringer @ldelossa @pchaigno @qmonnet
0