install/helm: Add Image Override Option to All Images #18849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1271f94 to
aba9f12
Compare
joestringer
approved these changes
Feb 17, 2022
sayboras
reviewed
Feb 17, 2022
install/kubernetes/cilium/templates/cilium-operator/_helpers.tpl
Outdated
Show resolved
Hide resolved
In order to enable offline deployment for certain platforms (like OpenShift) we need to be able to have a universal override for all images so that the OpenShift certified operator can list its "related images"[1][2]. [1]https://docs.openshift.com/container-platform/4.9/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs [2]https://redhat-connect.gitbook.io/certified-operator-guide/appendix/offline-enabled-operators Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
aba9f12 to
0285646
Compare
michi-covalent
approved these changes
Feb 23, 2022
|
/test |
|
This seems good to merge and low-risk, just wanted to know that the helm |
kaworu
approved these changes
Feb 25, 2022
8000
|
@kaworu @nathanjsweet The Travis CI failure was ignored here and broke master. |
This was referenced Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable offline deployment for certain
platforms (like OpenShift) we need to be able to have
a universal override for all images so that
the OpenShift certified operator can list its
"related images"1 2.
Signed-off-by: Nate Sweet nathanjsweet@pm.me