8000 Makefile: generate coverage for privileged unit tests by christarazi · Pull Request #11375 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Makefile: generate coverage for privileged unit tests #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2020
Merged

Makefile: generate coverage for privileged unit tests #11375

merged 3 commits into from
May 7, 2020

Conversation

christarazi
Copy link
Member
@christarazi christarazi commented May 6, 2020 •
edited
Loading

See commit messages.

christarazi added 2 commits May 6, 2020 13:23
@christarazi
Makefile: generate coverage for privileged tests
18c30c7 
The `tests-privileged` target previously did not generate coverage.
This commit adds the ability to generate coverage which is useful when
developing on privileged tests.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Makefile: new target to share coverage init logic
be9f43b 
This removes the duplication between normal unprivileged unit tests and
privileged unit tests.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@christarazi christarazi changed the title See commit messages. Makefile: generate coverage for privileged unit tests May 6, 2020
@christarazi christarazi added area/build Anything to do with the build, more general than area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note labels May 6, 2020
@christarazi christarazi marked this pull request as ready for review May 6, 2020 20:37
@christarazi
Copy link
Member Author

test-me-please

@coveralls
Copy link
coveralls commented May 6, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 42.642% when pulling 9f5bfc1 on christarazi:pr/christarazi/makefile-priv-tests-cov into a7f8fc8 on cilium:master.

joestringer
joestringer approved these changes May 6, 2020
View reviewed changes
Copy link
Member
@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor nit that could be cleaned up below.

@christarazi
Makefile: move dir cleanup to generate-cov target
9f5bfc1 
This simplifies the unit-tests and test-privileged as they both had this
logic after generating coverage.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Copy link
Member Author
christarazi commented May 6, 2020 •
edited
Loading

test-me-please

Edit: travis hit flake #11373
Edit2: hit #11385

@christarazi christarazi mentioned this pull request May 7, 2020
Closed
@christarazi
Copy link
Member Author

restart-ginkgo

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 7, 2020
@joestringer joestringer merged commit 61c2b4d into cilium:master May 7, 2020
@christarazi christarazi deleted the pr/christarazi/makefile-priv-tests-cov branch May 7, 2020 18:28
@joestringer joestringer mentioned this pull request May 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general than area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christarazi @coveralls @joestringer
0