8000 Remove boost by surgura · Pull Request #7 · ci-group/MultiNEAT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove boost #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Feb 23, 2022
Merged

Remove boost #7

merged 30 commits into from
Feb 23, 2022

Conversation

surgura
Copy link
@surgura surgura commented Feb 17, 2022

No description provided.

portaloffreedom
portaloffreedom reviewed Feb 21, 2022
View reviewed changes
Copy link
Member
@portaloffreedom portaloffreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work! I've added a few notes, but I don't think they should be blocking this PR. They are rather future notes.

CMakeLists.txt
MultiNEAT
PRIVATE
PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/src>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/multineat>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably link to the cereal::cereal imported interface so it would add the include directory if cereal is installed in a non-standard folder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cereal is no marked as a requirement(see comment at findPackage). I'm also not familiar with the syntax used here. Can you maybe add it?

portaloffreedom
portaloffreedom approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member
@portaloffreedom portaloffreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work :D

Aart Stuurman and others added 28 commits February 23, 2022 15:11
@surgura
Replace boost unordered map with std
74e3423
@surgura
Fix warning
64efc1b
@surgura
fix wranings
79951e9
@surgura
Removed boost serialization and added cereal. Compiles. did not check…
63d5fae 
… python package yet.
@surgura
Python also works
c25cdca
@surgura
Fix python tests. Fix bug where serialization wasn ot complete
7e61537
@surgura
Cannot the warnings :( I thought I fixed but apparently I didn't. Rem…
21ab8de 
…oved boost::ptrs
@surgura
Replaced boost::variant with std
c98d29c
@surgura
Remove boost random
1307754
@surgura
Remove boost::acumulators
3c9a9bf
@surgura
Fix test, but it doesn't work anyway because it already didn´t.
af895c2
@surgura
Cleanup
b643a9c
@surgura
Rewrite CMakeLists
fa8f2bd
@surgura
Removed boost python
0450e83
@surgura
Remove boost datetime
02afe5f
@surgura
Remove boost submodule
663b64d
@surgura
Cleanup last of boost
b18e559
@surgura
Test
6380e83
@surgura
Test
35459c0
@surgura
Fix'
66f32ee
@surgura
Update readme
560dbbf
@surgura
Typo
1d6cc7d
@surgura
Fix lib instal ldir
7d89e32
@surgura
Clean up graph
d7cfd3b
@surgura
Fix typo
af34f85
@surgura
Remove required cereal from config cmake
9dfc663
@surgura
Removed rng global state
d61530a
@surgura
Make cereal required
6fb008f
@surgura surgura merged commit b10551a into master Feb 23, 2022
@surgura surgura deleted the remove_boost branch February 23, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portaloffreedom portaloffreedom portaloffreedom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surgura @portaloffreedom
0