Added font family as an option to be passed in. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,7 @@ | |||
| this.icon = icon; | |||
| this.opacity = 0.4; | |||
| this.canvas = document.createElement('canvas'); | |||
| this.font = "Helvetica, Arial, 'sans serif'"; | |||
There was a problem hiding this comment.
Would you mind giving this a quick change:
this.font = "Helvetica, Arial, sans-serif";|
@elsewares Thanks for pr! Out of curiosity, what font are you thinking about using? |
|
No problem - it's a great solution for things like notifications. I was interested to see how well it would work with webfonts - specifically PT Sans and PT Serif. I'm also trying to figure out how to get the background to pulse. |
chrishunt
added a commit
that referenced
this pull request
Sep 25, 2013
Added font family as an option to be passed in.
chrishunt
pushed a commit
that referenced
this pull request
Sep 25, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy peasy.