8000 Add dockerfile by chrieke · Pull Request #46 · chrieke/prettymapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add dockerfile #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add dockerfile #46

wants to merge 6 commits into from

Conversation

chrieke
Copy link
Owner
@chrieke chrieke commented Jan 31, 2024

As intended in #42 adds Dockerfile & readme instrunctions.

But keeps the same code folder structure.

@chrieke chrieke mentioned this pull request Jan 31, 2024
Merged
Saibamen
Saibamen suggested changes Feb 4, 2024
View reviewed changes
Copy link
@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cleanup suggestions to reduce final docker image size, based on https://github.com/google-deepmind/alphafold/ repo

Dockerfile
@@ -0,0 +1,19 @@
FROM python:3.11-slim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use latest 3.12 if is possible

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrieke ?

chrieke and others added 3 commits February 5, 2024 18:58
@chrieke @Saibamen
Update Dockerfile
b9a38c5 
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@chrieke @Saibamen
Update Dockerfile
c898a7b 
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@chrieke @Saibamen
Update Dockerfile
4f101fd 
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@chrieke
Copy link
Owner Author
chrieke commented Feb 5, 2024 •
edited
Loading

Thank you @Saibamen, pushes it down to 1.57GB. Now hopefully the fiona issue can be resolved without installing gdal.

@Saibamen
Copy link
Saibamen commented Feb 5, 2024

pushes it down to 1.57GB

How much it was before?

Saibamen
Saibamen suggested changes Feb 5, 2024
View reviewed changes
Dockerfile
@@ -0,0 +1,19 @@
FROM python:3.11-slim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrieke ?

@chrieke
Copy link
Owner Author
chrieke commented Apr 20, 2024

Closing, Dockerfile added in #42

@chrieke chrieke closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saibamen Saibamen Saibamen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrieke @Saibamen
0