Chrivers/apiv1 error handling rework #134

chrivers · 2025-05-09T20:05:35Z

Rework api V1 error handling.

Previously, any non-successful api operation on the legacy api would yield incorrect error responses. Yes, even the errors were in error!

This did not help application compatibility, but the problem is now fixed consistently.

…ch hue bridge

…eld unless requested

…mpl IntoResponse"

…) error responses in v1 api

…rect error mapping

chrivers added 11 commits May 9, 2025 21:43

* Make HueError::WrongType map to http status 404 (not found) to mat…

f65c842

…ch hue bridge

- Remove obsolete HueError::UpdateUnsupported variant

a82458d

+ Implement type for v1 api errors in hue crate (referenced from htt…

406777e

…ps://github.com/peter-murray/node-hue-api/)

* Make POST responses to /api (new user response) skip .clientkey fi…

9f07a1b

…eld unless requested

* Make clip route handlers exclusively use ApiV2Result instead of "i…

a0d2903

…mpl IntoResponse"

fixup for hueapi error

f12a496

* Assign error codes as discriminants to HueApiV1Error

e3696a8

+ Introduce ApiV1Result and ApiV1Error, for better (actually correct…

c0717ba

…) error responses in v1 api

+ Add ApiV1Error::V1CreateUnsupported variant

04b09ba

* Make all api v1 route handlers use ApiV1Result type, to ensure cor…

44e5b0e

…rect error mapping

- Remove obsolete ApiError::V1CreateUnsupported

829e996

chrivers merged commit dff6b84 into master May 9, 2025
1 check passed

chrivers deleted the chrivers/apiv1-error-handling-rework branch May 9, 2025 20:09

Provide feedback