8000 (cmake)(cmake.install) Update note for PATH to new defaults by iTob191 · Pull Request #2651 · chocolatey-community/chocolatey-packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(cmake)(cmake.install) Update note for PATH to new defaults #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

(cmake)(cmake.install) Update note for PATH to new defaults #2651

merged 1 commit into from
May 6, 2025

Conversation

iTob191
Copy link
Contributor
@iTob191 iTob191 commented Apr 13, 2025 •
edited
Loading

Update Readme and install script to current cmake defaults.

Description

The installer automatically adds cmake to the PATH starting with version 3.0.30. Also the respective installer argument takes the values 0 and 1 (legacy values are still supported though).

See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9386

Motivation and Context

The readme and warning on the CLI are outdated / wrong.

How Has this Been Tested?

I have installed cmake in a windows sandbox environment using chocolatey and verified that it does indeed add itself to the path by default. Also running choco install cmake.install --installargs 'ADD_CMAKE_TO_PATH=0' prevents this behavior.
Given that the only functional change is the removal of Write-Warning, this should be sufficient.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My pull request is not coming from the master branch.
  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment. Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@pauby
Copy link
Member
pauby commented Apr 13, 2025

Thanks for the PR.

Unfortunately, it cannot go forward as it has not been tested in the correct environment and has not been done in line with the Contributing Guidelines.

@iTob191
Copy link
Contributor Author
iTob191 commented Apr 13, 2025 •
edited
Loading

has not been done in line with the Contributing Guidelines.

I have checked the item in the checklist and added the missing "Motivation and Context" section. Apart from this, is there anything else that violates the guidelines?

it cannot go forward as it has not been tested in the correct environment

I have since reproduced my tests from above in the chocolatey test environment with the same outcome.

@pauby
Copy link
Member
pauby commented May 6, 2025

This looks good to me. Thanks for the PR @iTob191!

@pauby pauby merged commit b8d5102 into chocolatey-community:master May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iTob191 @AppVeyorBot @pauby
0