8000 (tixati.portable) fix updater and update package to v3.33 by Jarcho · Pull Request #2655 · chocolatey-community/chocolatey-packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

(tixati.portable) fix updater and update package to v3.33 #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(tixati.portable) fix updater and update package to v3.33 #2655

wants to merge 1 commit into from

Conversation

Jarcho
< 8000 clipboard-copy aria-label="Copy link" for="issue-3007174167-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link
Contributor
@Jarcho Jarcho commented Apr 20, 2025 •
edited
Loading

Description

Fixes both the updater and the install script to handle the download being split between x86/x64 versions.

Motivation and Context

The website layout for downloads has changed and broke the updater.

How Has this Been Tested?

The updater has been tested locally. Package install/uninstall has been tested locally and in the test environment.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My pull request is not coming from the master branch.
  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment. Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@pauby
Copy link
Member
pauby commented May 7, 2025

@Jarcho this is an automatic package so the only file that should be being updated is the update.ps1 file just the same as for the tixati package and PR in #2654

pauby
pauby requested changes May 7, 2 8000 025
View reviewed changes
automatic/tixati.portable/tixati.portable.nuspec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an automatic package, this file should not be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be reverted given the install script needs to change? Reverting this will mean the version in the nuspec won't match the checksums in the script until the updater runs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updater script will update the .nuspec file as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarcho @AppVeyorBot @pauby
0