Adds Argument Completers To Update_All Script #2498
Conversation
QOL improvement: being able to tab complete packages in the arguments for the update_all script for use when developing or testing packages. Name tab completes from the list of existing packages, ForcedPackages tab completes from existing packages _prioritising those already in Name_.
|
✅ Package verification completed without issues. PR is now pending human review |
|
I think this should be added to the packages template repository we have before it is added here. Can you create an issue about it over at https://github.com/chocolatey-community/chocolatey-packages-template (and probably a PR)? |
|
I apologise if I'm holding this wrong, but this feels to me like it doesn't belong here, but in the templates repository or even Chocolatey AU? |
|
@JPRuskin where did we leave this? |
Fair to say - I think it needs to be added to the template repository and here, as we have no specific process for updating this repo from the template to my knowledge (may be wrong). I don't think it needs to be added to AU, though I may be wrong (something similar could possibly be added to After @AdmiringWorm said that it needed to go in the template, I went to investigate that, as I hadn't considered it. When I went to create an issue and PR on the template repository, I had a hard time writing an issue that sounded sane (typical me) and then found @TheCakeIsNaOH had done an amazing refactor to update swathes of stuff in this PR. I didn't feel I could create a new PR until that one had been merged, so I gave it a review. I think it's still waiting on some AppVeyor testing back over here. I had a look at doing that myself but as I've not used AppVeyor in specific anger, I've chased it a few times but not felt confident signing off on that portion. |
|
@JPRuskin that PR has now been merged. |
Description
When running the
Update_All.ps1script,-Namecan now tab-complete from the list of existing packages in the specified root-directory, and ForcedPackages can tab complete from existing packages prioritising those already in Name.Definitely up for chatting if this actually fits other users, here, but I think it's a nice change to have - and it shouldn't break anyone else's workflow.
Motivation and Context
When testing PRs or branches, I frequently run Update_All with specific name or forced packages.
As a quality of life improvement, being able to tab complete packages in the arguments for the update_all script for use when developing or testing packages is pretty neat.
2024-07-03_14-05-26.mp4
How Has this Been Tested?
Tested locally on PowerShell 5.1.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] Breaking change (fix or feature that would cause existing functionality to change)[ ] Migrated package (a package has been migrated from another repository)Checklist:
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).[ ] I have updated the package description and it is less than 4000 characters.[ ] All files are up to date with the latest Contributing Guidelines[ ] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.[ ] The changes only affect a single package (not including meta package).