avoid crash on spurious empty file in the pending_notifications dir #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
notification queue handling has a lot of tests. could you write another one to test for handling of spurious files there? |
added a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create
enforceE2EEincomingfor every maildir folder in/home/vmail/mail/DOMAIN/I was not aware that there is apending_notificationsfolder there, hard to realize when you have hundreds of folders there, it could happen to other people in general is better to be more resilient and just ignore such invalid files and delete them instead of crashing forever, dovecot process will fail badly then trying to connect to an nonexistent/run/chatmail-metadata/metadata.socket