Update supports-color to v10.0.0
8000
#640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "types": "./source/index.d.ts", | |||
| "sideEffects": false, | |||
| "engines": { | |||
| "node": "^12.17.0 || ^14.13 || >=16.0.0" | |||
| "node": ">=18" | |||
There was a problem hiding this comment.
We don't plan to do a major release for Node.js 18 support. It's not worth having to do a major release.
There was a problem hiding this comment.
Oops, you're totally right! I have simplified my approach in #642, which supersedes this PR
|
This is superseded by #642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #639, the vendored
supports-coloronly properly handlesnavigatorbeingundefinedsince this commit, which was released in version v10.0.0.This updates the vendored
supports-colortov10.0.0to fix that issue.Initially, I copied the files over byte-for-byte and tried to fix errors with dependencies and CI. That was very silly, so I've simply applied the required changes from
supports-color(in a different branch).Closes #639