8000 Format area numbers in accessibility map by GabrielBruno24 · Pull Request #1408 · chairemobilite/transition · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Format area numbers in accessibility map #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree t 8000 o our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Format area numbers in accessibility map #1408

wants to merge 1 commit into from

Conversation

GabrielBruno24
Copy link
Collaborator
@GabrielBruno24 GabrielBruno24 commented Jun 23, 2025 •
edited
Loading

In the accessibility map tabs, format the area results depending on the current language, and add a plus in the difference column, making the results more legible to the user.

image
image

@GabrielBruno24 GabrielBruno24 requested a review from kaligrafy June 23, 2025 20:18
greenscientist
greenscientist reviewed Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@greenscientist greenscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there an equivalent of an sprintf function of something like that that would handle formating and add this already ? (instead of creating a new function ?

@GabrielBruno24 GabrielBruno24 changed the title In the accessibility comparison tab, add a plus to the numbers in the difference collumn if they are positive. Format area numbers in accessibility map Jun 25, 2025
@GabrielBruno24 GabrielBruno24 force-pushed the addPlusSignToPositiveDifference branch from 9ae4b37 to 3f7a042 Compare June 25, 2025 17:27
@GabrielBruno24
In the accessibility map tabs, format the area results depending on t…
cada25c 
…he current language, and add a plus in the difference column, making the results more legible to the user.
@GabrielBruno24 GabrielBruno24 force-pushed the addPlusSignToPositiveDifference branch from 3f7a042 to cada25c Compare June 25, 2025 17:29
@GabrielBruno24
Copy link
Collaborator Author

Isn't there an equivalent of an sprintf function of something like that that would handle formating and add this already ? (instead of creating a new function ?

I used toLocaleString to format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahini tahini tahini approved these changes

@kaligrafy kaligrafy Awaiting requested review from kaligrafy

@greenscientist greenscientist Awaiting requested review from greenscientist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabrielBruno24 @greenscientist @tahini
0