Add POIs to accessibility map #1406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ca5df6c to
3cf5de5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3cf5de5 to
4fe83c7
Compare
If POIs are imported in the database from open street map, the accessibility map stats will now fetch that data from the db and display the number of POIs in the accessibility polygon, as well as their categories. Fix: chairemobilite#1404
4fe83c7 to
9f3983e
Compare
tahini
requested changes
Jun 25, 2025
| accessiblePlacesCountByDetailedCategory: { [key in PlaceDetailedCategory]: number }; | ||
| }> => { | ||
| try { | ||
| const accessiblePlacesCountByCategory = categories.reduce( |
There was a problem hiding this comment.
ça prendrait des tests séquentiels pour cette fonction dans places.db.queries.test.ts. Il est important que toutes les fonctions BD soient bien testées de façon relativement exhaustive.
| @@ -165,6 +188,7 @@ describe('Test accessibility map with results', () => { | |||
| } | |||
| }; | |||
| mockedNodesDbCollection.mockResolvedValue({ type: 'FeatureCollection', features: [ node1, node2, node3 ] }); | |||
| mockedPlacesPOIsCount.mockResolvedValue({accessiblePlacesCountByCategory, accessiblePlacesCountByDetailedCategory}) | |||
There was a problem hiding this comment.
Tu ajoutes un mock avec une valeur resolved, mais il n'y a pas de tests qui l'utilise. Il faudrati valider que la fonction a été appelée avec les bonnes valeurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If POIs are imported in the database from open street map, the accessibility map stats will now fetch that data from the db and display the number of POIs in the accessibility polygon, as well as their categories. Fix: #1404