auth: pass a router to setup auth routes instead of app #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes chairemobilite#1392 Setting the routes on a router gives more flexibility to the caller to add middleware and prefix the paths to the auth routes. The app is a `Router`, but the reverse is not true. So we do not need to change the way those routes are set in the Transition app, as the express application in Transition is quite simple.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the auth routes setup to accept an Express Router instead of the full app, enabling callers to mount or prefix auth routes with custom middleware.
- Update default export signature from
express.Expresstoexpress.Router - Replace all
app.get/app.postcalls withrouter.get/router.post - Adjust unit tests to instantiate and mount a
Routeron the app
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/chaire-lib-backend/src/api/auth.routes.ts | Change function signature and route registrations to use Router |
| packages/chaire-lib-backend/src/api/tests/auth.routes.test.ts | Instantiate Router, register auth routes, and mount on app |
|
@kaligrafy ping on this review |
kaligrafy
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1392
Setting the routes on a router gives more flexibility to the caller to add middleware and prefix the paths to the auth routes.
The app is a
Router, but the reverse is not true. So we do not need to change the way those routes are set in the Transition app, as the express application in Transition is quite simple.