8000 Base objects refactoring: Person, Place, Segment, Junction, WorkPlace, SchoolPlace, Routing by kaligrafy · Pull Request #514 · chairemobilite/evolution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Base objects refactoring: Person, Place, Segment, Junction, WorkPlace, SchoolPlace, Routing #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2024
Merged

Base objects refactoring: Person, Place, Segment, Junction, WorkPlace, SchoolPlace, Routing #514

merged 3 commits into from
May 29, 2024

Conversation

kaligrafy
Copy link
Contributor

No description provided.

@kaligrafy kaligrafy marked this pull request as draft May 24, 2024 20:19
@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch from 549ff99 to 2cb2f13 Compare May 24, 2024 20:21
@kaligrafy kaligrafy marked this pull request as ready for review May 27, 2024 19:55
@kaligrafy kaligrafy requested a review from tahini May 27, 2024 19:55
kaligrafy added 2 commits May 27, 2024 15:56
@kaligrafy
Add new classes and tests for baseObjects
797fcc4 
Add Person class with work palces and school places
Add Place with children Work Place, SchoolPlace and Junction
@kaligrafy
add description to Person and Place classes
6785b9c
@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch from cb3d6f9 to 6785b9c Compare May 27, 2024 19:58
@kaligrafy kaligrafy changed the title Base objects refactoring2 Base objects refactoring: Person, Place, Segment, Junction, WorkPlace, SchoolPlace, Routing May 28, 2024
tahini
tahini reviewed May 28, 2024
View reviewed changes
Copy link
Contributor
@tahini tahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques questions ici et là.

Mais sinon, ça fait une bonne base, bien testée sur quoi bâtir!

@kaligrafy kaligrafy requested a review from tahini May 28, 2024 18:11
@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch 2 times, most recently from 34645b4 to 12042e4 Compare May 28, 2024 18:20
tahini
tahini requested changes May 29, 2024
View reviewed changes
Copy link
Contributor
@tahini tahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un peu de doc à ajouter pour les composed attributes. Sinon, c'est bon

@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch from 12042e4 to cf67bf7 Compare May 29, 2024 17:10
@kaligrafy kaligrafy requested a review from tahini May 29, 2024 17:11
@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch 2 times, most recently from b3cbc66 to c12ea91 Compare May 29, 2024 17:13
@kaligrafy
add tests for Segment and Routing
a7b79bf 
use a generic ROuting class instead of separate for transit and other modes

update tests to include getters with no setters

update ConstructorUtils for composed attributes
@kaligrafy kaligrafy force-pushed the baseObjectsRefactoring2 branch from c12ea91 to a7b79bf Compare May 29, 2024 17:14
@kaligrafy kaligrafy merged commit 708b0ac into chairemobilite:main May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-duhaime samuel-duhaime samuel-duhaime left review comments

@tahini tahini tahini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaligrafy @tahini @samuel-duhaime
0