Evolution: Add inputCheckboxTest for test UI #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahini
requested changes
May 23, 2024
| const checkbox = context.page.locator(`id=survey-question__${newPath}_${value}__input-checkbox__${value}`); | ||
| await checkbox.scrollIntoViewIfNeeded(); | ||
| await checkbox.click(); | ||
| await expect(checkbox).toBeChecked(); |
There was a problem hiding this comment.
Je me demande s'il ne faudrait pas checker l'état checked à la toute fin seulement? (tout d'in coup qu'on s'attendait à avoir 3 valeurs checked, mais que le widget a "accidentellement" décoché les valeurs cochées précédemment...)
En fait, on peut garder le check ici, et après la boucle for, il faudrait aller chercher les éléments checked et valider qu'ils correspondent à la valeur. Tu peux juste mettre un TODO ici au pire.
There was a problem hiding this comment.
Bonne idée. C'est fait.
Add inputCheckboxTest Format testHelper.ts
bf2cf0c to
a0bd67c
Compare
tahini
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Justification
We need to test inputCheckbox for some of our surveys (MJ, for example).
Description
Add inputCheckboxTest
Format testHelper.ts