inputs: let the checkbox and multiselect parse arrays #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the value parsing logic to natively support array inputs (e.g., checkboxes and multiselects) by introducing an asArray flag and a helper to detect array-based input types.
- Adds
isInputTypeWithArrayValueto identify inputs that should parse arrays. - Extends
parseValuein helpers to handle single vs. array values based onasArray. - Updates all calls to
parseValuein the frontend to pass the new flag and revises tests accordingly.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/evolution-frontend/src/components/survey/Question.tsx | Passes asArray to parseValue for checkbox/multiselect types |
| packages/evolution-frontend/src/actions/utils/WidgetOperation.ts | Same update as above in widget operation utility |
| packages/evolution-common/src/utils/helpers.ts | Refactors and overloads parseValue to support array parsing |
| packages/evolution-common/src/utils/tests/helpers.test.ts | Expands tests to cover both asArray=false and asArray=true |
| packages/evolution-common/src/services/questionnaire/types/WidgetConfig.ts | Adds isInputTypeWithArrayValue helper |
| packages/evolution-common/src/services/questionnaire/types/tests/WidgetConfig.test.ts | Adds tests for the new array‐detection helper |
Comments suppressed due to low confidence (2)
packages/evolution-common/src/services/questionnaire/types/tests/WidgetConfig.test.ts:84
- [nitpick] The describe block name 'isQuestionAnswerAnArray' does not match the function under test 'isInputTypeWithArrayValue'; updating it to reflect the actual function name would improve clarity.
describe('isQuestionAnswerAnArray', () => {
packages/evolution-common/src/utils/tests/helpers.test.ts:118
- Add test cases for parsing boolean and geojson types with
asArray=trueto ensure array parsing works correctly for these data types.
each([
Comment on lines
320
to
321
| export const isInputTypeWithArrayValue = (inputType: QuestionWidgetConfig['inputType']): boolean => | ||
| inputType === 'checkbox' || inputType === 'multiselect'; |
There was a problem hiding this comment.
[nitpick] Consider using a Set or array include check (e.g., ['checkbox', 'multiselect'].includes(inputType)) instead of hardcoded OR conditions to make this easier to extend in the future.
Suggested change
| export const isInputTypeWithArrayValue = (inputType: QuestionWidgetConfig['inputType']): boolean => | |
| inputType === 'checkbox' || inputType === 'multiselect'; | |
| const inputTypesWithArrayValues = ['checkbox', 'multiselect']; | |
| export const isInputTypeWithArrayValue = (inputType: QuestionWidgetConfig['inputType']): boolean => | |
| inputTypesWithArrayValues.includes(inputType); |
Copilot uses AI. Check for mistakes.
kaligrafy
approved these changes
Jun 17, 2025
fixes chairemobilite#1036 Add a `asArray` parameter to the `parseValue` function, which allows to specify if the expected value should be an array, but still convert to the correct datatype the values in the array. Add a `isInputTypeWithArrayValue` function to determine if the input type should give an array value. checkboxes and multiselects are inputs with array values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1036
Add a
asArrayparameter to theparseValuefunction, which allows to specify if the expected value should be an array, but still convert to the correct datatype the values in the array.Add a
isInputTypeWithArrayValuefunction to determine if the input type should give an array value. checkboxes and multiselects are inputs with array values.