paradata: log invisible widgets at the end of sections #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds tracking of widgets that were not visible when a user leaves a section or clicks a button, and includes those hidden widget paths in both the frontend update flow and the backend export CSV.
- Frontend now computes hidden widget paths and attaches them to
UserActionduring updates and navigation. UserActiontype is extended to include an optionalhiddenWidgetsarray.- Backend export logic includes a
hiddenWidgetscolumn in CSV output, and tests are updated accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evolution-frontend/src/actions/tests/Survey.test.ts | Added tests to verify hiddenWidgets in update and navigation. |
| packages/evolution-frontend/src/actions/Survey.ts | Implemented getHiddenWidgets and enhanced user actions. |
| packages/evolution-common/src/services/questionnaire/types/Data.ts | Extended UserAction type with optional hiddenWidgets. |
| packages/evolution-backend/src/services/adminExport/exportInterviewLogs.ts | Exported hiddenWidgets in CSV rows. |
| packages/evolution-backend/src/services/adminExport/tests/exportInterviewLogs.test.ts | Updated export tests to assert hiddenWidgets field. |
| event_date: new Date((2) * 1000).toISOString(), | ||
| modifiedFields: modifiedKeys, | ||
| initializedFields: initializedKeys, | ||
| unsetFields: buttonLogs[1].unset_paths !== undefined ? buttonLogs[0].unset_paths.join('|') : '', |
There was a problem hiding this comment.
In the second button_click row assertion, the test uses buttonLogs[0].unset_paths but should use buttonLogs[1].unset_paths to match the second log entry.
Suggested change
| unsetFields: buttonLogs[1].unset_paths !== undefined ? buttonLogs[0].unset_paths.join('|') : '', | |
| unsetFields: buttonLogs[1].unset_paths !== undefined ? buttonLogs[1].unset_paths.join( |
Copilot uses AI. Check for mistakes.
| event_date: new Date((2) * 1000).toISOString(), | ||
| modifiedFields: modifiedKeys2, | ||
| initializedFields: initializedKeys2, | ||
| unsetFields: sectionChangeLogs[1].unset_paths !== undefined ? sectionChangeLogs[0].unset_paths.join('|') : '', |
There was a problem hiding this comment.
In the second section_change row assertion, the test references sectionChangeLogs[0].unset_paths instead of sectionChangeLogs[1].unset_paths, causing a mismatch with the second log.
Suggested change
| unsetFields: sectionChangeLogs[1].unset_paths !== undefined ? sectionChangeLogs[0].unset_paths.join('|') : '', | |
| unsetFields: sectionChangeLogs[1].unset_paths !== undefined ? sectionChangeLogs[1].unset_paths.join('|') : '', |
Copilot uses AI. Check for mistakes.
fixes chairemobilite#1016 When the user navigates to another section or when a button is clicked, we save the list of hidden widgets on the current section so we can know which widgets were seen by the participant or not. Update log export to add the hidden widgets
samuel-duhaime
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1016
When the user navigates to another section or when a button is clicked, we save the list of hidden widgets on the current section so we can know which widgets were seen by the participant or not.
Update log export to add the hidden widgets