8000 Update expected messages of `type_check` errors by toslunar · Pull Request #8407 · chainer/chainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update expected messages of type_check errors #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

toslunar
Copy link
Member

The documentation fix after #4680.

Error messages are not checked by default because of IGNORE_EXCEPTION_DETAIL in doctest_default_flags.

8000
@toslunar toslunar added the cat:document Documentation such as function documentations, comments and tutorials. label Nov 11, 2019
@niboshi
Copy link
Member
niboshi commented Nov 12, 2019

LGTM
Jenkins, test this please

@niboshi niboshi added to-be-backported Pull request that should be backported. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Nov 12, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 12, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c70dd76, target branch master) succeeded!

@mergify mergify bot merged commit a03db57 into chainer:master Nov 12, 2019
@toslunar toslunar deleted the argname-doc branch November 12, 2019 08:46
@chainer-ci
Copy link
Member

@niboshi This pull-request is marked as to-be-backported, but the corresponding backport PR coul 8000 d not be found. Could you check?

niboshi pushed a commit to niboshi/chainer that referenced this pull request Nov 19, 2019
Update expected messages of `type_check` errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0