latest changes - PR instead of rebase #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut and version) (bitcoin#2121) The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state while they should really be in PRE_ENABLED state. The fix is to split this verification in two parts - this way sentinel version is only checked after at least one ping is received from the masternode itself and not from the cold wallet.
We don't relay mnb if sync is still in progress. Creating mnb without relaying it only increases inconsistency and leads to user confusion. Unifying conditions for creation and relaying fixes this.
Instead just mark them as MASTERNODE_UPDATE_REQUIRED and proceed further.
* PrepareDenominate fix * Fix conditions
…itcoin#2157) Messages should be serialized according the protocol of the peer who asked us or otherwise peers running on other protocols won't be able to deserialize the message correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.