8000 log repository name by rudymatela · Pull Request #182 · channable/hoff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

log repository name #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2022
Merged

log repository name #182

merged 4 commits into from
Aug 31, 2022

Conversation

rudymatela
Copy link
@rudymatela rudymatela commented Aug 31, 2022 •
edited
Loading

Closes: #171

This updates some logging to include the relevant repository name.

"Posted comment on 182" now becomes "Posted comment on hoff#182".

Logs after the change

Starting Hoff v0.27.2
Config file: config.json
Read-only: False
Loaded project state from './run/state/git-sandbox.json'.
[Info] logic loop received event (git-sandbox): Synchronize
[Debug] state before (git-sandbox): ProjectState ...
[Debug] Getting open pull request in .../git-sandbox.
Listening for webhooks on port 1979.
[Debug] Got 6 open pull requests in .../git-sandbox.
[Debug] state after (git-sandbox): ProjectState ...
[Debug] github loop received event: Comment (CommentPayload {action = Left CommentCreated, owner = "...", repository = "git-sandbox", number = 144, author = Username "rudymatela", body = "This is a comment."})
[Info] logic loop received event (git-sandbox): CommentAdded (PullRequestId 144) (Username "rudymatela") "This is a comment."
[Debug] state before (git-sandbox): ProjectState ...
[Debug] state after (git-sandbox): ProjectState ...
...
[Info] Posted comment on git-sandbox#12345: Pull request approved for merge and deploy by @rudymatela, waiting for rebase behind one pull request.
[Info] Posted comment on git-sandbox#12345: Speculatively rebased as 0123456789abcdef behind #12346, waiting for CI …

Above ⬆️, we know exactly to which repository each log entry belongs to.

Logs before the change

Starting Hoff v0.27.2
Config file: config.json
Read-only: False
Loaded project state from './run/state/git-sandbox.json'.
[Info] logic loop received event: Synchronize
[Debug] state before: ProjectState ...
[Debug] Getting open pull request in .../git-sandbox.
Listening for webhooks on port 1979.
[Debug] Got 6 open pull requests in .../git-sandbox.
[Debug] state after: ProjectState ...
[Debug] github loop received event: Comment (CommentPayload {action = Left CommentCreated, owner = "...", repository = "git-sandbox", number = 144, author = Username "rudymatela", body = "This is a comment."})
[Info] logic loop received event: CommentAdded (PullRequestId 144) (Username "rudymatela") "This is a comment."
[Debug] state before: ProjectState ...
[Debug] state after: ProjectState ...
...
[Info] Posted comment on 12345: Pull request approved for merge and deploy by @rudymatela, waiting for rebase behind one pull request.
[Info] Posted comment on 12345: Speculatively rebased as 0123456789abcdef behind #12346, waiting for CI …

Above ⬆️, if we are tracking multiple projects/repositories in the log, we have no way to know which log entry belongs to which repo.

@rudymatela rudymatela self-assigned this Aug 31, 2022
@rudymatela rudymatela added the enhancement New feature or request label Aug 31, 2022
@rudymatela
remove uneeded repository name from log entry
2a9bc36 
... that already contains the repository name
@rudymatela
Copy link
Author
rudymatela commented Aug 31, 2022 •
edited
Loading

@xrvdg, @alexfedotov or @alex-mckenna Can either of you please review? One is enough, whoever has free time first. :-) first-come-first-merged.

@rudymatela 8000 rudymatela marked this pull request as ready for review August 31, 2022 12:05
alex-mckenna
alex-mckenna approved these changes Aug 31, 2022
View reviewed changes
Copy link
@alex-mckenna alex-mckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, definitely makes the log more traceable if you're watching multiple repos

@rudymatela
Copy link
Author

@alex-mckenna Thanks for the review.

@OpsBotPrime merge

@OpsBotPrime
Copy link

Pull request approved for merge by @rudymatela, rebasing now.
8000

@OpsBotPrime
Merge #182: log repository name
a27e6c8 
Approved-by: rudymatela
Auto-deploy: false
@OpsBotPrime
Copy link

Rebased as a27e6c8, waiting for CI …

@OpsBotPrime
Copy link

CI job 🟡 started.

@OpsBotPrime OpsBotPrime merged commit a27e6c8 into master Aug 31, 2022
@OpsBotPrime OpsBotPrime deleted the log-repository branch August 31, 2022 12:24
@rudymatela rudymatela mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-mckenna alex-mckenna alex-mckenna approved these changes

Assignees

@rudymatela rudymatela

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log repository name beside PR number
3 participants
@rudymatela @OpsBotPrime @alex-mckenna
0