Improve markdown in comments for CI job started and build failed
#156
Conversation
|
@DanielNoord Thanks for the addition. 😄 Tests are passing here. I will merge this myself later this week after I merge #137. |
|
... I am "assigning" this to me so I don't forget to merge it later. @DanielNoord I've marked you as an assignee as well, so you can have the clear credits when I merge (feel free to unnasign yourself if you rather it not appear under your main GH issues tab). |
Thanks! Wouldn't it show up anyway? My account should appear in the commit tree of the repo right? |
You're right, it will. I just wanted to make the credits clearer. :-) |
|
@OpsBotPrime merge on Friday |
|
Pull request approved for merge by @rudymatela, waiting for rebase behind 2 pull requests. |
|
Failed to rebase, please rebase manually using |
|
@OpsBotPrime merge on Friday |
|
Pull request approved for merge by @rudymatela, rebasing now. |
|
Rebased as e02641f, waiting for CI … |
…`build failed`` Approved-by: rudymatela Auto-deploy: false
|
CI job started. |
|
@rudymatela Not sure if this due to the recent merge train change, but this PR seems to have been merged to |
I will close it now. I don't think this is related to the merge trains change. Usually GitHub closes PRs automatically when they are merged into the main branch. In this case, it failed to detect that the branch was merged because it was from a different remote repository. I think that this issue has always been present with Hoff... Perhaps when it detects the branch is from a different remote, it should post a comment stating that the PR has been merged but that it should be closed manually, or something else appropriate. I will create an issue soon when I have the time and link it here. |
|
This is a merge train example. #160 |
Closes #151
I ran into various issues trying to test this locally. For example,
stackassumesnixis installed which wasn't listed as a requirement. (Note the If using Nix in the README).Either way, since this is a fairly trivial markdown change I thought I would still submit the PR.
Let me know if this requires any changes 😄