8000 [pull] master from jstedfast:master by pull[bot] · Pull Request #8 · chanhong/MimeKit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[pull] master from jstedfast:master #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1,051 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link
@pull pull bot commented Mar 12, 2021

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

jstedfast and others added 14 commits July 11, 2024 09:21
Bumps [NUnit.ConsoleRunner](https://github.com/nunit/nunit-console) from 3.17.0 to 3.18.1.
- [Release notes](https://github.com/nunit/nunit-console/releases)
- [Changelog](https://github.com/nunit/nunit-console/blob/main/CHANGES.txt)
- [Commits](nunit/nunit-console@3.17.0...3.18.1)

---
updated-dependencies:
- dependency-name: NUnit.ConsoleRunner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [AltCover](https://github.com/SteveGilham/altcover) from 8.8.74 to 8.8.173.
- [Release notes](https://github.com/SteveGilham/altcover/releases)
- [Changelog](https://github.com/SteveGilham/altcover/blob/master/ReleaseNotes.md)
- [Commits](SteveGilham/altcover@release/v8.8.74...release/v8.8.173)

---
updated-dependencies:
- dependency-name: AltCover
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [altcover.global](https://github.com/SteveGilham/altcover) from 8.8.74 to 8.8.173.
- [Release notes](https://github.com/SteveGilham/altcover/releases)
- [Changelog](https://github.com/SteveGilham/altcover/blob/master/ReleaseNotes.md)
- [Commits](SteveGilham/altcover@release/v8.8.74...release/v8.8.173)

---
updated-dependencies:
- dependency-name: altcover.global
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](nunit/nunit3-vs-adapter@V4.5.0...V4.6.0)

---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is useful to automatically convert strings to typed InternetAddress subclasses. For example, when using the `Microsoft.Extensions.Configuration` package.
…nverter

Also fixed coding style and XML doc comments a bit.
Bumps [NUnit.Analyzers](https://github.com/nunit/nunit.analyzers) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/nunit/nunit.analyzers/releases)
- [Changelog](https://github.com/nunit/nunit.analyzers/blob/master/CHANGES.md)
- [Commits](nunit/nunit.analyzers@4.2.0...4.3.0)

---
updated-dependencies:
- dependency-name: NUnit.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.12 to 0.14.0.
- [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases)
- [Commits](dotnet/BenchmarkDotNet@v0.13.12...v0.14.0)

---
updated-dependencies:
- dependency-name: BenchmarkDotNet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jstedfast and others added 30 commits April 26, 2025 16:24
(extremely long meaning the length exceeds the buffer length)

We do this by assuming that any line >= 1000 octets is definitely *not* a
boundary marker.

Also added other smarts to consume partial lines that can't possibly be a
boundary marker to avoid re-scanning over the same input bytes in the next
pass.
When instantiating DSACryptoServiceProvider or RSACryptoServiceProvider,
use a minimum key size value of 2048 in order to satisfy static analysis
tools.

Technically, this is not needed because we import the key information that
we exported from BouncyCastle, so this isn't generating a *new* DSA or
RSA key which means the key size is effectively ignored but it satisfies
static analysis tools that don't understand this.
Previously, as long as there were 2 or more "words" before a comma in the name,
even if AllowUnquotedCommasInAddresses was false, it would happily parse the
address.

After this change, it will not.
* Add unit test for FilteredStream throwing ObjectDisposedExceptions

* Check if disposed on FilteredStream filter manipulation
Fixes a leak in MimeAnonymizer and MimeUtils.Unquote

Fixes issue #1161
It does not return a parsed message. Oops!
This way we eliminate disk I/O inconsistencies between runs and should,
at least in theory, get more accurate comparison data.

In fairness, the downside of this is that any performance gains or losses
will be amplified compared to normal usage (which I assume will be parsing
FileStreams as opposed to MemoryStreams).
This gets us a 20-30% performance improvement when parsing messages
from a MemoryStream.

Probably closer to 5-10% performance improvement for FileStreams since
File I/O is such a huge factor in overall MimeReader speed.

(see diff for Benchmarks.md for actual numbers)
Like the previous MimeReader optimization patch, this gets us a 20-30%
performance improvement when parsing messages from a MemoryStream.

Probably closer to 5-10% performance improvement for FileStreams since
File I/O is such a huge factor in overall MimeParser speed.

(see diff for Benchmarks.md for actual numbers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0