ABCL passing all CFFI tests #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form to keep ABCL happy * This is a nasty hack and shouldn't be needed, but it appears that the define-setf-expander is not available for expansion later in the file on ABCL unless we wrap it in an eval-when --HG-- extra : source : cf6e7c6dbd000f75bae8749cc2877048f9e5f889
* call lispify-value on args to lisp callback functions, which requires passing the argument-types to covnert-args-to-lisp-values * clean up invocation of convert-args-to-lisp-values --HG-- extra : source : f0243b58f8a6a7644fdb56a81d43e7d88cb21cc9
--HG-- extra : source : d5cf2b188977b265208b29264886f95b4bd0ebc4
--HG-- extra : source : bd8a12402ed0379efea026d56946480d64f8b717
--HG-- extra : source : 689ed9effbee9370ce862b3a5f5e0340318b87ee
--HG-- extra : source : 7149ff7634cf44757e7b0716362f4db5edabe254
--HG-- extra : source : 9b8dda7d534f834534ae3da5d0f4bca75fbae928
* we get passed the actual library object, so no need to look it up in *loaded-libaries* --HG-- extra : source : 2ff7572b6e2891dca25cc98f04e83407ef5cea53
--HG-- extra : source : 950b3fbe05c97a458b33351d9b0e5b461fca15f7
… value doesn't need to be lispified --HG-- extra : source : c31849290804b1f4991f6b5b191431d5b5dd457d
…nside lispify-value --HG-- extra : source : 3d9851ba117c14ae5c64626d603ec8a5954c7020
* but cheat and return nil in foreign-free because that's what it's supposed to return --HG-- extra : source : e799a650f5f4376b1839b836a2646d7a55598fbc
--HG-- extra : source : b2914504481ed5299ff81bd497c91a5f24b364b7
--HG-- extra : source : ad241bab3932d854064c94d828c67e8c42726d9b
use closures with variables to cache various methods to avoid a lot of introspection --HG-- extra : source : 15b29046c5efff647292ad590078cb7e403f5cd9
* call java:jobject-lisp-value directly instead of lispify-value in copy-from-foreign-vector as it is much faster --HG-- extra : source : eb3c481e4aebb81d85573d5139d6fb3c72ba0d03
|
Superseded by #44. |
luismbo
added a commit
that referenced
this pull request
Sep 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the hard work of Cyrus Harmon and Olof-Joachim Frahm over the past six months, the code in this pull request passes all CFFI tests with ABCL.