8000 Add unhealthyPodEvictionPolicy to supported PDB options by jcpunk · Pull Request #7728 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add unhealthyPodEvictionPolicy to supported PDB options #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add unhealthyPodEvictionPolicy to supported PDB options #7728

wants to merge 1 commit into from

Conversation

jcpunk
Copy link
@jcpunk jcpunk commented May 2, 2025

Pull Request Motivation

unhealthyPodEvictionPolicy is a feature of the podDisruptionBudget, so it is nice to be able to set it via the chart.

Currently the chart ignores this value when set.

Kind

/kind feature

Release Note

Added suport for unhealthyPodEvictionPolicy in PodDisruptionBudget

@cert-manager-prow cert-manager-prow bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration labels May 2, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2025
@cert-manager-prow
Copy link
Contributor

Hi @jcpunk. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2025
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 2, 2025
@jcpunk
Add unhealthyPodEvictionPolicy to supported PDB options
f740eba 
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@erikgb
Copy link
Contributor
erikgb commented May 2, 2025

@jcpunk Thanks for your PR. Have you seen #7537?

@jcpunk
Copy link
Author
jcpunk commented May 2, 2025 •
edited
Loading

I did not. Weird, I'd swear I searched for PRs before writing this...

Whichever you prefer to merge is fine with me.

@erikgb erikgb mentioned this pull request May 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcpunk @erikgb
0