8000 7196 order reason not set by ScreenTurnOn · Pull Request #7658 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

7196 order reason not set #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

7196 order reason not set #7658

wants to merge 1 commit into from

Conversation

ScreenTurnOn
Copy link

Pull Request Motivation

This PR is motivated by issue #7196 and conversations that started at KubeCon EU 2025 in Cert Manager's Contribfest event.

Kind

/kind bug

Release Note

We are propagating the Reason why a failed Order into the state of the k8s resource.

Work in progress...

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/deploy Indicates a PR modifies deployment configuration labels Apr 4, 2025
@cert-manager-prow
Copy link
Contributor

Hi @ScreenTurnOn. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing area/vault Indicates a PR directly modifies the Vault Issuer code kind/design Categorizes issue or PR as related to design. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2025
@ScreenTurnOn ScreenTurnOn force-pushed the 7196-order-reason-not-set branch from eb93d28 to 2143b14 Compare April 4, 2025 09:15
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 4, 2025
@ScreenTurnOn ScreenTurnOn force-pushed the 7196-order-reason-not-set branch 2 times, most recently from af76518 to f52c36e Compare April 4, 2025 11:57
@ScreenTurnOn ScreenTurnOn changed the base branch from 7196-order-reason-not-set to master April 4, 2025 11:58
@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2025
@SgtCoDFish
Copy link
Member

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2025
@maelvls maelvls removed area/api Indicates a PR directly modifies the 'pkg/apis' directory area/vault Indicates a PR directly modifies the Vault Issuer code area/testing Issues relating to testing area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code labels Apr 7, 2025
@maelvls maelvls removed area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/monitoring Indicates a PR or issue relates to monitoring area/deploy Indicates a PR modifies deployment configuration labels Apr 7, 2025
@maelvls @ScreenTurnOn
troubleshooting my new test
6c29a63 
Signed-off-by: ScreenTurnOn <screen.turn.on@pm.me>
@ScreenTurnOn ScreenTurnOn force-pushed the 7196-order-reason-not-set branch from f52c36e to 6c29a63 Compare April 7, 2025 10:51
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2025
@cert-manager-prow
Copy link
Contributor

@ScreenTurnOn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-make-verify 6c29a63 link true /test pull-cert-manager-master-make-verify
pull-cert-manager-master-make-test 6c29a63 link true /test pull-cert-manager-master-make-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScreenTurnOn @SgtCoDFish @maelvls
0