8000 RBD: update VolumeGroupContext by iPraveenParihar · Pull Request #5376 · ceph/ceph-csi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RBD: update VolumeGroupContext #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

RBD: update VolumeGroupContext #5376

merged 2 commits into from
Jun 25, 2025

Conversation

iPraveenParihar
Copy link
Contributor
@iPraveenParihar iPraveenParihar commented Jun 20, 2025 •
edited
Loading

Describe what this PR does

This PR includes below changes -

  • updates the VolumeGroupContext field with the key-value
    pairs available in the CreateVolumeGroupRequest.

  • Update VolumeGroupReplicationContent controller to get
    VolumeGroupAttributes from VolumeGroupReplicationContent CR
    instead of VolumeGroupReplicationClass.

Fixes: #5220

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@iPraveenParihar iPraveenParihar force-pushed the vgr/update-volumegroupcontext branch 3 times, most recently from 9e0687f to b40d829 Compare June 23, 2025 07:20
nixpanic
nixpanic reviewed Jun 23, 2025
View reviewed changes
@iPraveenParihar iPraveenParihar marked this pull request as ready for review June 23, 2025 07:46
iPraveenParihar
iPraveenParihar commented Jun 23, 2025
View reviewed changes
go.mod
@@ -16,7 +16,7 @@ require (
github.com/ceph/ceph-csi/api v0.0.0-00010101000000-000000000000
github.com/ceph/go-ceph v0.34.0
github.com/container-storage-interface/spec v1.11.0
github.com/csi-addons/kubernetes-csi-addons v0.12.0
github.com/csi-addons/kubernetes-csi-addons v0.10.1-0.20250619114017-8816325e2e14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used the github.com/csi-addons/kubernetes-csi-addons@main to get the required changes from csi-addons for this PR.

Do we wait for next csi-addons release to merge this PR? @Madhu-1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not stall this PR. once we have release before ceph-csi release we can update to next release

Madhu-1
Madhu-1 reviewed Jun 23, 2025
View reviewed changes
Copy link
Collaborator
@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if there are CR's present in the cluster or are using older version of csi-addons CR's? did we test it out?

@iPraveenParihar
Copy link
Contributor Author

What will happen if there are CR's present in the cluster or are using older version of csi-addons CR's? did we test it out?

didn't test this scenario, but yea this will result in panic as the older version CR will not have the VolumeGroupReplicationContent.Spec.VolumeGroupAttributes field.

Either we can tie ceph-csi version with this change with the required csi-addons version or handle gracefully by falling back to VolumeGroupReplicationClass for fetching the parameters?

@Madhu-1
Copy link
Collaborator
Madhu-1 commented Jun 23, 2025

What will happen if there are CR's present in the cluster or are using older version of csi-addons CR's? did we test it out?

didn't test this scenario, but yea this will result in panic as the older version CR will not have the VolumeGroupReplicationContent.Spec.VolumeGroupAttributes field.

Either we can tie ceph-csi version with this change with the required csi-addons version or handle gracefully by falling back to VolumeGroupReplicationClass for fetching the parameters?

we should have fall back as we need to support the older version of CR's as well.

@iPraveenParihar iPraveenParihar force-pushed the vgr/update-volumegroupcontext branch from b40d829 to 6b60bee Compare June 23, 2025 11:14
@iPraveenParihar iPraveenParihar requested a review from Madhu-1 June 24, 2025 11:00
Rakshith-R
Rakshith-R reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor
@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Madhu-1
Madhu-1 reviewed Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, LGTM

@iPraveenParihar iPraveenParihar force-pushed the vgr/update-volumegroupcontext branch from 6b60bee to 6d36321 Compare June 24, 2025 12:11
Madhu-1
Madhu-1 previously approved these changes Jun 24, 2025
View reviewed changes
@Madhu-1 Madhu-1 requested a review from Rakshith-R June 24, 2025 12:20
@iPraveenParihar iPraveenParihar force-pushed the vgr/update-volumegroupcontext branch from 6d36321 to 8811751 Compare June 24, 2025 14:26
@mergify mergify bot dismissed Madhu-1’s stale review June 24, 2025 14:26

Pull request has been modified.

@Nikhil-Ladha
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 24, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify bot added a commit that referenced this pull request Jun 24, 2025
@mergify
Merge of #5376
f74d47e
@mergify mergify bot mentioned this pull request Jun 24, 2025
Closed
78 tasks
@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/k8s-e2e-external-storage/1.31

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/k8s-e2e-external-storage/1.33

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.32

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.33

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e/k8s-1.32

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e/k8s-1.33

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/upgrade-tests-cephfs
869

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/upgrade-tests-rbd

@iPraveenParihar
Copy link
Contributor Author

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 25, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@iPraveenParihar @mergify
rbd: update VolumeGroupContext
03dd171 
This commit updates the VolumeGroupContext field with the key-value
pairs available in the CreateVolumeGroupRequest.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar @mergify
rbd: make use of VolumeGroupAttributes
aeeeeea 
Update VolumeGroupReplicationContent controller to get
VolumeGroupAttributes from VolumeGroupReplicationContent CR
instead of VolumeGroupReplicationClass.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify mergify bot force-pushed the vgr/update-volumegroupcontext branch from 8811751 to aeeeeea Compare June 25, 2025 06:03
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jun 25, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 25, 2025
mergify bot added a commit that referenced this pull request Jun 25, 2025
@mergify
Merge of #5376
ab51a61
@mergify mergify bot merged commit 2f8d341 into ceph:devel Jun 25, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

@Nikhil-Ladha Nikhil-Ladha Awaiting requested review from Nikhil-Ladha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dont use volumegroupreplicationclass when generating the omap
6 participants
@iPraveenParihar @Madhu-1 @Nikhil-Ladha @ceph-csi-bot @nixpanic @Rakshith-R
0