util: pass Servers by reference to serve() #5354
Conversation
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3ff34e5 |
This commit modifies nonBlockingGRPCServer.serve() to accept Servers parameter by reference rather than value to prevent copy of a large struct. Signed-off-by: Rakshith R <rar@redhat.com>
543d58a to
d8dae31
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
This commit modifies nonBlockingGRPCServer.serve() to accept Servers parameter by reference rather
than value to prevent copy of a large struct.
related-to : #5351
Missed in #5351
linter is still failing at https://github.com/ceph/ceph-csi/actions/runs/15466994254/job/43541315936?pr=5347
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)