helm: Support VolumeSnapshotClass and VolumeGroupSnapshotClass #5240
Conversation
2519f3a to
83e6c07
Compare
|
Hi @hswong3i, thanks for the PR! Could you remove the publishing of the charts from your commit? There is a job already, and it pushes the charts to the https://github.com/ceph/csi-charts repository. |
@nixpanic dummy https://github.com/helm/chart-releaser-action integration removed, also update |
|
Thanks for the update @hswong3i! I've glanced over it just now, and this looks better than the previous version. It needs a more careful look to check the parameters/values before I feel confident enough to approve it. |
Because the table contents are too complicated for manual formatting, so I am using 'pandoc -f gfm -t gfm --wrap preserve' for format linting. |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
charts/ceph-csi-cephfs/values.yaml
Outdated
Show resolved
Hide resolved
14491cc to
dd3139d
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
|
/test ci/centos/mini-e2e/k8s-1.33 |
|
This pull request has been removed from the queue for the following reason: Pull request #5240 has been 6D40 dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
This PR add support for creating VolumeSnapshotClass and VolumeGroupSnapshotClass with helm charts. Both default with `create: false` as StorageClass support. Moreover, it handle the chart release with branch `gh-pages`, by integrate with <https://github.com/helm/chart-releaser-action>. The sample helm repo could find from <https://alvistack.github.io/ceph-ceph-csi/index.yaml>, by: helm repo add ceph-csi https://alvistack.github.io/ceph-ceph-csi helm repo update helm search repo ceph-csi Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Pull request has been modified.
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1a01311 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
Describe what this PR does
This PR add support for creating VolumeSnapshotClass and VolumeGroupSnapshotClass with helm charts. Both default with
create: falseas StorageClass support.Moreover, it handle the chart release with branch
gh-pages, by integrate with https://github.com/helm/chart-releaser-action.The sample helm repo could find from https://alvistack.github.io/ceph-ceph-csi/index.yaml, by:
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer guide.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)