8000 MON-150244-remove-whitelist-from-40-gorgoned-yaml-file-for-new-plateform by Evan-Adam · Pull Request #2399 · centreon/centreon-collect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MON-150244-remove-whitelist-from-40-gorgoned-yaml-file-for-new-plateform #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

MON-150244-remove-whitelist-from-40-gorgoned-yaml-file-for-new-plateform #2399

merged 1 commit into from
Jul 9, 2025

Conversation

Evan-Adam
Copy link
Contributor

Description

Action module should be specified in its own file to simplify whitelist modification in the future.

Fixes # MON-150244

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@Evan-Adam Evan-Adam requested review from a team as code owners May 27, 2025 16:54
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 27, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Evan-Adam
fix(gorgone): remove double action module declaration
d6ede2a 
Action module should be specified in its own file to simplify whitelist modification in the future.

Refs:MON-150244
@Evan-Adam Evan-Adam force-pushed the MON-150244-remove-whitelist-from-40-gorgoned-yaml-file-for-now-plateform branch from 29fdcb8 to d6ede2a Compare May 27, 2025 16:55
@github-actions GitHub Actions
Copy link

Logo
Checkmarx One – Scan Summary & Details – 68526b3c-b885-4334-8155-2cc316a9a72e

Great job, no security vulnerabilities found in this Pull Request

@cg-tw
Copy link
Contributor
cg-tw commented Jul 3, 2025

Approved so as not to block the merge.

@Evan-Adam Evan-Adam merged commit 083a255 into develop Jul 9, 2025
31 of 32 checks passed
@Evan-Adam Evan-Adam deleted the MON-150244-remove-whitelist-from-40-gorgoned-yaml-file-for-now-plateform branch July 9, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuntoja tuntoja tuntoja approved these changes

@cg-tw cg-tw cg-tw approved these changes

@scresto31 scresto31 scresto31 approved these changes

@smau-centreon smau-centreon Awaiting requested review from smau-centreon smau-centreon is a code owner automatically assigned from centreon/owners-doc

@mushroomempires mushroomempires Awaiting requested review from mushroomempires mushroomempires is a code owner automatically assigned from centreon/owners-pipelines

Assignees
No one assigned
Labels
skip-workflow-gorgone skip-workflow-gorgone-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Evan-Adam @cg-tw @tuntoja @scresto31
0