8000 fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package by vuntz · Pull Request #2300 · centreon/centreon-collect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package #2300

merged 1 commit into from
Apr 22, 2025

Conversation

vuntz
Copy link
Member
@vuntz vuntz commented Apr 14, 2025 •
edited by jira bot
Loading

On Alma9, this module has been split out and needs to be explicitly installed. On Alma8, it worked fine as it is part of perl-interpreter -- but the new dependency will not be a problem as perl-interpreter provides it.

On Debian 11 and 12, the Tie::File perl module is part of the perl-modules packages; no need to do anything.

Description

Fixes #MON-158852

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • 24.10.x
  • master

@vuntz
fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package
128b096 
On Alma9, this module has been split out and needs to be explicitly installed.
On Alma8, it worked fine as it is part of perl-interpreter -- but the new
dependency will not be a problem as perl-interpreter provides it.

On Debian 11 and 12, the Tie::File perl module is part of the perl-modules
packages; no need to do anything.
@vuntz vuntz requested a review from a team as a code owner April 14, 2025 15:51
@vuntz vuntz requested review from kduret and mushroomempires April 14, 2025 15:51
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 14, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vuntz vuntz merged commit 7ee6631 into develop Apr 22, 2025
23 checks passed
@vuntz vuntz deleted the MON-158852-mbi-Tie-File-packaging branch April 22, 2025 07:23
vuntz added a commit that referenced this pull request May 6, 2025
@vuntz
fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package (…
19be853 
…#2300)

On Alma9, this module has been split out and needs to be explicitly installed.
On Alma8, it worked fine as it is part of perl-interpreter -- but the new
dependency will not be a problem as perl-interpreter provides it.

On Debian 11 and 12, the Tie::File perl module is part of the perl-modules
packages; no need to do anything.
vuntz added a commit that referenced this pull request May 6, 2025
@vuntz
fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package (…
168e4df 
…#2300)

On Alma9, this module has been split out and needs to be explicitly installed.
On Alma8, it worked fine as it is part of perl-interpreter -- but the new
dependency will not be a problem as perl-interpreter provides it.

On Debian 11 and 12, the Tie::File perl module is part of the perl-modules
packages; no need to do anything.
This was referenced May 6, 2025
Merged
Merged
vuntz added a commit that referenced this pull request May 6, 2025
@vuntz
fix(packaging): Add perl(Tie::File) dependency in gorgone rpm package (…
fb5ae5a 
…#2300)

On Alma9, this module has been split out and needs to be explicitly installed.
On Alma8, it worked fine as it is part of perl-interpreter -- but the new
dependency will not be a problem as perl-interpreter provides it.

On Debian 11 and 12, the Tie::File perl module is part of the perl-modules
packages; no need to do anything.
@vuntz vuntz mentioned this pull request May 6, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kduret kduret kduret approved these changes

@tuntoja tuntoja tuntoja approved these changes

@mushroomempires mushroomempires Awaiting requested review from mushroomempires mushroomempires is a code owner automatically assigned from centreon/owners-pipelines

Assignees
No one assigned
Labels
skip-workflow-gorgone skip-workflow-gorgone-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuntz @kduret @tuntoja
0