MON-157180-v2-gorgone-cloud-poller-disconnect-when-gorgone-log-are-to-big-to-be-sent #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
29dce0f to
23b071d
Compare
15 tasks
23b071d to
493503a
Compare
…wss connexion mode Refs:MON-157180
…ther host if needed. - getlog() always order select query by id. - pullwss module split any GETLOG message to stay bellow the websocket message size limit and transform them in SETLOGS. For now if a message is lost in transmission it will never be asked again for. An error message will be present in the central log file. The split is made in the pullwss and not in send_internal_action because the http api use the same GETLOG message locally, which would be broken if messages are split. the new behaviour allow the api to send back as many logs as needed, and to split log only for pullwss connexion method. The other connexion method use zmq that don't have a size limit. MON-157180
…ral. Refs:MON-157180
Refs:MON-157180
Refs:MON-157180
493503a to
9f78c07
Compare
Refs:MON-157180
Refs:MON-157180
15 tasks
Refs:MON-157180
Refs:MON-157180
… fix a condition in the code Refs:MON-157180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix pullwss and core gorgone module to spilt the log sync message to stay under the websocket message size.
Add a sequence diagram of the log retrieval.
Fixes # MON-157180
Type of change
Target serie
How this pull request can be tested ?
See automated tests, run 2 gorgone and create many log in the poller database. Then wait for a log synchronization (around 5 secs? ) and check the data are correctly added in the central sqlite database.
select count(*) , token from gorgone_history group by token;
Checklist