8000 Mon 155836 process check by jean-christophe81 · Pull Request #2268 · centreon/centreon-collect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mon 155836 process check #2268

< 8000 summary id="button-9aea9816180054c9" class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 8, 2025
Merged

Mon 155836 process check #2268

merged 14 commits into from
Apr 8, 2025

Conversation

jean-christophe81
Copy link
Contributor

REFS: MON-155836

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 2, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jean-christophe81 jean-christophe81 force-pushed the MON-155836-process_check branch from b12a2af to 11a2fca Compare April 2, 2025 14:46
@jean-christophe81 jean-christophe81 marked this pull request as ready for review April 3, 2025 05:26
@jean-christophe81 jean-christophe81 requested review from a team as code owners April 3, 2025 05:26
@jean-christophe81 jean-christophe81 requested a review from a team as a code owner April 3, 2025 13:36
@jean-christophe81 jean-christophe81 force-pushed the MON-155836-process_check branch from 8565963 to 2c77e21 Compare April 4, 2025 05:49
@mushroomempires mushroomempires mentioned this pull request Apr 4, 2025
Merged
15 tasks
@mushroomempires @jean-christophe81
suggestion(ci): suggestion on PR-2268 on step duplication (#2270)
6e31393 
* fix connector ssh test

* suggestion(ci): suggestion on PR-2268 on step duplication

* remove duplicate step + fix variable linting

---------

Co-authored-by: Jean Christophe Roques <jcroques@centreon.com>
@jean-christophe81 jean-christophe81 force-pushed the MON-155836-process_check branch from 73e15bb to fcf6e57 Compare April 4, 2025 15:23
bouda1
bouda1 approved these changes Apr 7, 2025
View reviewed changes
@jean-christophe81 @bouda1
Update agent/native_windows/inc/com/centreon/agent/check_process.hh
afc3c4d 
Co-authored-by: David Boucher <dboucher@centreon.com>
@jean-christophe81 jean-christophe81 merged commit 9e985d8 into develop Apr 8, 2025
26 checks passed
@jean-christophe81 jean-christophe81 deleted the MON-155836-process_check branch April 8, 2025 04:13
jean-christophe81 added a commit that referenced this pull request Apr 8, 2025
@jean-christophe81
Mon 165590 process check (#2268)
e6578e2 
enh(agent): native process check
fix(agent): native service check
fix(nightly): connector ssh robot
enh(vcpkg): use of 2025.03.19 vcpkg version
jean-christophe81 added a commit that referenced this pull request Apr 8, 2025
@jean-christophe81
Mon 165590 process check (#2268) (#2273)
4f3f18a 
enh(agent): native process check
fix(agent): native service check
fix(nightly): connector ssh robot
enh(vcpkg): use of 2025.03.19 vcpkg version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouda1 bouda1 bouda1 approved these changes

@mushroomempires mushroomempires mushroomempires approved these changes

@Evan-Adam Evan-Adam Awaiting requested review from Evan-Adam Evan-Adam is a code owner automatically assigned from centreon/owners-robot-e2e

@tuntoja tuntoja Awaiting requested review from tuntoja tuntoja is a code owner automatically assigned from centreon/owners-pipelines

Assignees
No one assigned
Labels
skip-workflow-centreon-collect skip-workflow-docker-collect-testing skip-workflow-docker-packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jean-christophe81 @bouda1 @mushroomempires
0