8000 fix: redundant re-evaluations by ernisto · Pull Request #51 · centau/vide · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: redundant re-evaluations #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

fix: redundant re-evaluations #51

wants to merge 26 commits into from

Conversation

ernisto
Copy link
@ernisto ernisto commented Mar 15, 2025

benchmark on Ryzen 7 5700X3D before, and after this PR
image

@ernisto ernisto marked this pull request as draft March 15, 2025 16:35
@ernisto
Copy link
Author
ernisto commented Mar 15, 2025

rejected due increased complexity on dependency tree to just fix some edge cases.
so i will just keep it as a draft in case it be used at least for strict mode

ernisto added 18 commits March 15, 2025 20:48
@ernisto
chore: remove brother requires older brother print()
edd6afd
@ernisto
test: rename brother requires older brother to `older brother requi…
1721c19 
…res newer brother`
@ernisto
fix: make springs and maps update descendants as root update
d8149f0
@ernisto
fix: dont bump update_id if batch are enabled
c078bd8
@ernisto
fix(graph): avoid repeatedly child of the same parent
21ed76f
@ernisto
refactor: move parameter root_update_id to a new function `bump_upd…
54abda6 
…ate_id`
@ernisto
fix(graph): update children if the output is the same, but is a un-fr…
7350cf1 
…ozen table
@ernisto
feat: derive no longer run twice
fb30f84
@ernisto
fix(maps/values): modify directly next input cache instead of defer…
36eb9b0 
… to end

- solves test `destruction of active scope in values` without twice runs
@ernisto
fix: no longer bump update id when a map updates
f510fdf
@ernisto
fix: mark node validity before effect
3478640 
- still is possible recursive effects if bump update id (expected)
- fix some edge cases of undesirable queuing evaluating nodes
@ernisto
revert: fix(graph): avoid repeatedly child of the same parent (#21ed76f)
ecbdae6 
- we had performance issues on benchmark `update 500->1 graph`
@ernisto
perf: no longer store needs_queue_children, queue directly on `eval…
b282a02 
…uate_node`
@ernisto
perf: we dont need check if update_id is higher than `higher_parent…
eb75693 
…_update_id`
@ernisto
test: add benchmark update 1000->1 graph that updates only 1 depend…
71e5963 
…ency
@ernisto
test: benchmark update all parents of 500->1 graph now have 1000 de…
04388ec 
…pendencies
@ernisto
fix: evaluate derive, maps and switch on read, always before pu…
e115372 
…sh child
@ernisto
perf: batch springs
6ce4d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ernisto
0