8000 fix: resolve issue #9569 by supporting distinct broker transport options for workers by yiyu0x · Pull Request #9695 · celery/celery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: resolve issue #9569 by supporting distinct broker transport options for workers #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2025

Conversation

yiyu0x
Copy link
Contributor
@yiyu0x yiyu0x commented May 7, 2025

This pull request introduces support for a new setting BEAT_DBURI, which allows specifying the database URI for Celery Beat.

The main purpose of this change is to ensure that the password portion of the URI is properly masked in logs and diagnostic outputs, improving security and preventing sensitive credentials from being exposed.

Fixes #9569

@Nusnus Nusnus self-requested a review May 7, 2025 22:08
@Nusnus Nusnus added this to the 5.5.3 milestone May 7, 2025
Copy link
codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (c7bb67f) to head (46eb4a6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9695   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files         153      153           
  Lines       19127    19127           
  Branches     2533     2533           
=======================================
  Hits        15015    15015           
+ Misses       3822     3820    -2     
- Partials      290      292    +2     
Flag Coverage Δ
unittests 78.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member
@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have a PR for this #9646 and we should go for the first one. I am bit confused though. should we only change this or should we also change the other check option too which was suggested in the issue?

@auvipy auvipy merged commit b6cab29 into celery:main May 18, 2025
18 of 19 checks passed
github-merge-queue bot pushed a commit to Software-Engineering-Jagiellonian/django-celery-frege that referenced this pull request Jun 6, 2025
Bumps [celery[redis]](https://github.com/celery/celery) from 5.5.2 to
5.5.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/celery/celery/releases">celery[redis]'s
releases</a>.</em></p>
<blockquote>
<h2>v5.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>make the tests run on python 3.13 for gcs backend by <a
href="https://github.com/auvipy"><code>@​auvipy</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9677">celery/celery#9677</a></li>
<li>Added DeepWiki to README by <a
href="https://github.com/Nusnus"><code>@​Nusnus</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9683">celery/celery#9683</a></li>
<li>Limit redis to &lt;=v5.2.1 to match Kombu by <a
href="https://github.com/Nusnus"><code>@​Nusnus</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9693">celery/celery#9693</a></li>
<li>Use EX_OK instead of literal zero by <a
href="https://github.com/Nusnus"><code>@​Nusnus</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9684">celery/celery#9684</a></li>
<li>Make wheel metadata reproducible by <a
href="https://github.com/cjwatson"><code>@​cjwatson</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9687">celery/celery#9687</a></li>
<li>let celery install from kombu dependencies for better align by <a
href="https://github.com/auvipy"><code>@​auvipy</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9696">celery/celery#9696</a></li>
<li>Fix stamping documentation to clarify stamped_headers key is
optional in visitor methods by <a
href="https://github.com/Nusnus"><code>@​Nusnus</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9697">celery/celery#9697</a></li>
<li>Support apply_async without queue argument on quorum queues by <a
href="https://github.com/bityob"><code>@​bityob</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9686">celery/celery#9686</a></li>
<li>Updated rabbitmq doc about using quorum queues with task routes by
<a href="https://github.com/bityob"><code>@​bityob</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9707">celery/celery#9707</a></li>
<li>Add: Dumper Unit Test by <a
href="https://github.com/yiyu0x"><code>@​yiyu0x</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9711">celery/celery#9711</a></li>
<li>Add unit test for event.group_from by <a
href="https://github.com/rogerforlife"><code>@​rogerforlife</code></a>
in <a
href="https://redirect.github.com/celery/celery/pull/9709">celery/celery#9709</a&g
8000
t;</li>
<li>refactor: add beat_cron_starting_deadline documentation warning by
<a href="https://github.com/alirafiei75"><code>@​alirafiei75</code></a>
in <a
href="https://redirect.github.com/celery/celery/pull/9712">celery/celery#9712</a></li>
<li>fix: resolve issue <a
href="https://redirect.github.com/celery/celery/issues/9569">#9569</a>
by supporting distinct broker transport options for workers by <a
href="https://github.com/yiyu0x"><code>@​yiyu0x</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9695">celery/celery#9695</a></li>
<li>Fixes issue with retry callback arguments in DelayedDelivery by <a
href="https://github.com/maccinza"><code>@​maccinza</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9708">celery/celery#9708</a></li>
<li>get_exchange-unit-test by <a
href="https://github.com/rogerforlife"><code>@​rogerforlife</code></a>
in <a
href="https://redirect.github.com/celery/celery/pull/9710">celery/celery#9710</a></li>
<li>ISSUE-9704: Update documentation of result_expires, filesystem
backend is supported by <a
href="https://github.com/MattiasDC"><code>@​MattiasDC</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9716">celery/celery#9716</a></li>
<li>update to blacksmith ubuntu 24.04 by <a
href="https://github.com/auvipy"><code>@​auvipy</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9717">celery/celery#9717</a></li>
<li>Added unit tests for celery.utils.iso8601 by <a
href="https://github.com/jaiganeshs21"><code>@​jaiganeshs21</code></a>
in <a
href="https://redirect.github.com/celery/celery/pull/9725">celery/celery#9725</a></li>
<li>Update introduction.rst docs by <a
href="https://github.com/auvipy"><code>@​auvipy</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9728">celery/celery#9728</a></li>
<li>Prepare for release: v5.5.3 by <a
href="https://github.com/Nusnus"><code>@​Nusnus</code></a> in <a
href="https://redirect.github.com/celery/celery/pull/9732">celery/celery#9732</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bityob"><code>@​bityob</code></a> made
their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9686">celery/celery#9686</a></li>
<li><a href="https://github.com/yiyu0x"><code>@​yiyu0x</code></a> made
their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9711">celery/celery#9711</a></li>
<li><a
href="https://github.com/rogerforlife"><code>@​rogerforlife</code></a>
made their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9709">celery/celery#9709</a></li>
<li><a
href="https://github.com/alirafiei75"><code>@​alirafiei75</code></a>
made their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9712">celery/celery#9712</a></li>
<li><a href="https://github.com/maccinza"><code>@​maccinza</code></a>
made their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9708">celery/celery#9708</a></li>
<li><a href="https://github.com/MattiasDC"><code>@​MattiasDC</code></a>
made their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9716">celery/celery#9716</a></li>
<li><a
href="https://github.com/jaiganeshs21"><code>@​jaiganeshs21</code></a>
made their first contribution in <a
href="https://redirect.github.com/celery/celery/pull/9725">celery/celery#9725</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/celery/celery/compare/v5.5.2...v5.5.3">https://github.com/celery/celery/compare/v5.5.2...v5.5.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/celery/celery/blob/main/Changelog.rst">celery[redis]'s
changelog</a>.</em></p>
<blockquote>
<h1>5.5.3</h1>
<p>:release-date: 2025-06-01
:release-by: Tomer Nosrati</p>
<p>What's Changed</p>
<pre><code>
- make the tests run on python 3.13 for gcs backend
([#9677](celery/celery#9677))
- Added DeepWiki to README
([#9683](celery/celery#9683))
- Limit redis to &lt;=v5.2.1 to match Kombu
([#9693](celery/celery#9693))
- Use EX_OK instead of literal zero
([#9684](celery/celery#9684))
- Make wheel metadata reproducible
([#9687](celery/celery#9687))
- let celery install from kombu dependencies for better align
([#9696](celery/celery#9696))
- Fix stamping documentation to clarify stamped_headers key is optional
in visitor methods
([#9697](celery/celery#9697))
- Support apply_async without queue argument on quorum queues
([#9686](celery/celery#9686))
- Updated rabbitmq doc about using quorum queues with task routes
([#9707](celery/celery#9707))
- Add: Dumper Unit Test
([#9711](celery/celery#9711))
- Add unit test for event.group_from
([#9709](celery/celery#9709))
- refactor: add beat_cron_starting_deadline documentation warning
([#9712](celery/celery#9712))
- fix: resolve issue
[#9569](celery/celery#9569) by supporting
distinct broker transport options for workers
([#9695](celery/celery#9695))
- Fixes issue with retry callback arguments in DelayedDelivery
([#9708](celery/celery#9708))
- get_exchange-unit-test
([#9710](celery/celery#9710))
- ISSUE-9704: Update documentation of result_expires, filesystem backend
is supported ([#9716](celery/celery#9716))
- update to blacksmith ubuntu 24.04
([#9717](celery/celery#9717))
- Added unit tests for celery.utils.iso8601
([#9725](celery/celery#9725))
- Update introduction.rst docs
([#9728](celery/celery#9728))
- Prepare for release: v5.5.3
([#9732](celery/celery#9732))
<p>.. _version-5.5.2:
</code></pre></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/celery/celery/commit/088c39c0f78b23a9cdf8d1c9e265ea64d02cfd86"><code>088c39c</code></a>
Prepare for release: v5.5.3 (<a
href="https://redirect.github.com/celery/celery/issues/9732">#9732</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/0c1c52b7c361b65c286b30b13973df741799f4ea"><code>0c1c52b</code></a>
Update introduction.rst docs (<a
href="https://redirect.github.com/celery/celery/issues/9728">#9728</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/778b009ffbad7c7d8061a4e7cc4c4445ec541da3"><code>778b009</code></a>
Added unit tests for celery.utils.iso8601 (<a
href="https://redirect.github.com/celery/celery/issues/9725">#9725</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/b00c1446d809b8909c4932674c49a7659838aaa6"><code>b00c144</code></a>
update to blacksmith ubuntu 24.04</li>
<li><a
href="https://github.com/celery/celery/commit/5aae2ca5f455e148cd59de89907459265c5b81fc"><code>5aae2ca</code></a>
ISSUE-9704: Update documentation of , filesystem backend is supported if
cele...</li>
<li><a
href="https://github.com/celery/celery/commit/7cf9d8987017ee6414644ff7bf32756860255d2a"><code>7cf9d89</code></a>
get_exchange-unit-test (<a
href="https://redirect.github.com/celery/celery/issues/9710">#9710</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/b06e53f324f0cfe2b1c98b99d7a8a158d7034dea"><code>b06e53f</code></a>
Fixes issue with retry callback argument types in DelayedDelivery (<a
href="https://redirect.github.com/celery/celery/issues/9708">#9708</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/b6cab29e6932f100c9f30706ce2600ccff5e14e3"><code>b6cab29</code></a>
fix: resolve issue <a
href="https://redirect.github.com/celery/celery/issues/9569">#9569</a>
by supporting distinct broker transport options for ...</li>
<li><a
href="https://github.com/celery/celery/commit/5fc068cd4561ddddebaa5abdde947a90105fa59e"><code>5fc068c</code></a>
refactor: add beat_cron_starting_deadline documentation warning (<a
href="https://redirect.github.com/celery/celery/issues/9712">#9712</a>)</li>
<li><a
href="https://github.com/celery/celery/commit/c7bb67f7412c61477473299ae2f251d5731be3c1"><code>c7bb67f</code></a>
Add unit test for event.group_from (<a
href="https://redirect.github.com/celery/celery/issues/9709">#9709</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/celery/celery/compare/v5.5.2...v5.5.3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=celery[redis]&package-manager=pip&previous-version=5.5.2&new-version=5.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clerey inspect report leaking beat_dburi password
3 participants
0