fix(crontab): resolve constructor type conflicts #9551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9551 +/- ##
==========================================
- Coverage 78.24% 78.24% -0.01%
==========================================
Files 153 153
Lines 19040 19040
Branches 2520 2520
==========================================
- Hits 14898 14897 -1
Misses 3856 3856
- Partials 286 287 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Feb 8, 2025
auvipy
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
crontabclass constructor parameter types conflict with actual functionality. The parameter cron spec values are marked asstr, but can actually beint | str | Iterable[int].This creates a type alias called
Cronspecto represent the correct types, and then uses it to fix typing inconsistencies.