8000 Allow passing Celery objects to the Click entry point by 0x2b3bfa0 · Pull Request #9426 · celery/celery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow passing Celery objects to the Click entry point #9426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2024
Merged

Allow passing Celery objects to the Click entry point #9426

merged 3 commits into from
Dec 1, 2024

Conversation

0x2b3bfa0
Copy link
Contributor
@0x2b3bfa0 0x2b3bfa0 commented Nov 21, 2024 •
edited
Loading

Fixes #9361 (comment) 🤦🏼

Note

I didn't expect the command-line entry point to be called from inside Celery with an object instead of a string. 🙃

Tip

C 8000 onsider enabling the hide whitespace option in the diff when reviewing this pull request.

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Nov 21, 2024
Merged
@0x2b3bfa0
Copy link
Contributor Author

🔔 @Nusnus & @david-elias-kuenstle-webcom

@codecov Codecov
Copy link
codecov bot commented Nov 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (3f2aed4) to head (02cc60a).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
celery/bin/celery.py 23.07% 9 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9426      +/-   ##
==========================================
- Coverage   78.16%   78.16%   -0.01%     
==========================================
  Files         153      153              
  Lines       19024    19025       +1     
  Branches     2517     2518       +1     
==========================================
  Hits        14870    14870              
  Misses       3866     3866              
- Partials      288      289       +1
Flag Coverage Δ
unittests 78.13% <23.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus self-requested a review November 21, 2024 10:51
Nusnus
Nusnus approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member
@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@Nusnus Nusnus merged commit eb559a6 into celery:main Dec 1, 2024
68 of 70 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch December 2, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nusnus Nusnus Nusnus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @Nusnus
0