8000 Allow custom hostname for celery_worker in celery.contrib.pytest / celery.contrib.testing.worker by SlowMo24 · Pull Request #9405 · celery/celery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow custom hostname for celery_worker in celery.contrib.pytest / celery.contrib.testing.worker #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2024
Merged

Allow custom hostname for celery_worker in celery.contrib.pytest / celery.contrib.testing.worker #9405

merged 3 commits into from
Nov 10, 2024

Conversation

SlowMo24
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

This PR introduces the functionality to use a user defined hostname during TestWorkerControlloer initiallisation. This is useful if the user wants to mimic the '-n'/'--hostname' CLI argument during testing.

Closes #9404

@SlowMo24 SlowMo24 marked this pull request as draft November 10, 2024 14:34
@SlowMo24 SlowMo24 marked this pull request as ready for review November 10, 2024 14:35
@SlowMo24
Copy link
Contributor Author

@Nusnus as stated in #9404 I hereby tag you to request a review :-)

@Nusnus Nusnus self-requested a review November 10, 2024 15:28
@codecov Codecov
Copy link
codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (53fa7bc) to head (45e04b1).
Report is 121 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9405   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files         151      151           
  Lines       18984    18984           
  Branches     2508     2508           
=======================================
  Hits        14836    14836           
  Misses       3860     3860           
  Partials      288      288
Flag Coverage Δ
unittests 78.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nusnus
Nusnus approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member
@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

P.s
The docker error is not related

@Nusnus Nusnus merged commit 80dff7d into celery:main Nov 10, 2024
69 of 71 checks passed
@auvipy auvipy added this to the 5.5.0 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nusnus Nusnus Nusnus approved these changes

Assignees
No one assigned
Labels
Category: Tests
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Allow custom hostname for celery_worker in celery.contrib.pytest / celery.contrib.testing.worker
3 participants
@SlowMo24 @Nusnus @auvipy
0