Fix for revoked tasks being moved to RETRY state #6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
This pull request fixes 2 alerts when merging be12d15 into 5d72aee - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6812 +/- ##
==========================================
- Coverage 70.73% 70.72% -0.01%
==========================================
Files 138 138
Lines 16605 16606 +1
Branches 2094 2095 +1
==========================================
Hits 11745 11745
Misses 4663 4663
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auvipy
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6793
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes 6793. (I assume the intention here was to do nothing if we do have a connection but self._already_revoked, not to _anounce_cancelled in that case as in the orginal code, which would wrongly move the state to RETRY.)