8000 Allow configuration of RedisBackend's health_check_interval by mrbcmorris · Pull Request #6666 · celery/celery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow configuration of RedisBackend's health_check_interval #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2021
Merged

Allow configuration of RedisBackend's health_check_interval #6666

merged 3 commits into from
Mar 16, 2021

Conversation

mrbcmorris
Copy link
Contributor
@mrbcmorris mrbcmorris commented Mar 8, 2021 •
edited
Loading

Description

👋 Hey folks,

Was working through a reliability issue on our end with our Redis connections and came across the need to update the health_check_interval for the underlying Redis connection. The goal here is a simple implementation that allows reading this value via environment variable (redis_backend_health_check_interval) and passing this through as a kwarg to the underlying redis-py module.

This is my proposed solution to #6665. Please let me know what you think and thank you for the great library.

Cheers,
Chris

@codecov
Copy link
codecov bot commented Mar 8, 2021 •
edited
Loading

Codecov Report

Merging #6666 (e367ddf) into master (07000d8) will decrease coverage by 5.13%.
The diff coverage is 11.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6666      +/-   ##
==========================================
- Coverage   75.60%   70.46%   -5.14%     
==========================================
  Files         138      138              
  Lines       16377    16497     +120     
  Branches     2052     2074      +22     
==========================================
- Hits        12382    11625     -757     
- Misses       3777     4669     +892     
+ Partials      218      203      -15
Flag Coverage Δ
unittests 70.46% <11.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/bin/amqp.py 0.00% <0.00%> (ø)
celery/bin/base.py 0.00% <0.00%> (ø)
celery/bin/beat.py 0.00% <0.00%> (ø)
celery/bin/call.py 0.00% <0.00%> (ø)
celery/bin/celery.py 0.00% <0.00%> (ø)
celery/bin/control.py 0.00% <0.00%> (ø)
celery/bin/events.py 0.00% <0.00%> (ø)
celery/bin/list.py 0.00% <0.00%> (ø)
celery/bin/migrate.py 0.00% <0.00%> (ø)
celery/bin/multi.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8492b75...e367ddf. Read the comment docs.

auvipy
auvipy requested changes Mar 9, 2021
View reviewed changes
@auvipy auvipy added this to the 5.1.0 milestone Mar 9, 2021
@lgtm-com
Copy link
lgtm-com bot commented Mar 9, 2021

This pull request introduces 1 alert when merging 6c7148b into f091bab - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

auvipy
auvipy reviewed Mar 10, 2021
View reviewed changes
@auvipy auvipy merged commit 36e4452 into celery:master Mar 16, 2021
@auvipy
Copy link
Member
auvipy commented Mar 16, 2021

thanks, both of you!

jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
@mrbcmorris @jeyrce
Allow configuration of RedisBackend's health_check_interval (celery#6666
ad6da0f 
)

* Allow configuration of RedisBackend health_check_interval

* Only add key if value is set

* Added documentation for the redis_backend_health_check_interval setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees

@thedrow thedrow

Labels
Component: Redis Results Backend PR Type: Feature
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Allow setting health_check_interval for Redis backends
2 participants
@mrbcmorris @auvipy
0