8000 Ccxtpro error handling by frosty00 · Pull Request #26278 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ccxtpro error handling #26278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2025
Merged

Ccxtpro error handling #26278

merged 7 commits into from
Jun 24, 2025
+100 −135

Conversation

frosty00
Copy link
Member

we revert #20609 and make error handling work

@carlosmiei
Copy link
Collaborator

@frosty00 before merging this I think we should test it well because there are a lot of use cases to test (close with pending futures, close without pending futures, using watch and watchMultiple, etc)

@pcriadoperez can you help test this ?

@carlosmiei
Copy link
Collaborator

@frosty00 Also, what exactly wasn't working?

@frosty00 frosty00 merged commit 53f95e7 into ccxt:master Jun 24, 2025
10 of 11 checks passed
@pcriadoperez
Copy link
Contributor

Hi, I know the PR has already been merged and I don't really have the context of the issue trying to be solved, but left here my two cents if its helpful:

  • The ExchangeClosedByUser error I believe this was introduced to differentiate when a future is rejected due to a user-initiated exchange.close()—essentially allowing the user to distinguish between graceful shutdowns and actual errors. That said, I assume it’s not widely used at the moment, so removing it might be safe.

  • On try/catch removal: While it's simpler, I’m always a bit cautious about removing try/catch blocks—especially around set_result, which can throw if the future is already done or cancelled.

  • When running test_close.py it fails at the test: Call watch_multiple unhandled futures are canceled with the message: Unexpected exception: Connector is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroitor kroitor Awaiting requested review from kroitor kroitor is a code owner

@carlosmiei carlosmiei Awaiting requested review from carlosmiei carlosmiei is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frosty00 @carlosmiei @pcriadoperez
0