10000 Add Exkoin exchange implementation by exreve · Pull Request #26276 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Exkoin exchange implementation #26276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

exreve
Copy link
@exreve exreve commented Jun 22, 2025

Add ExKoin Exchange Support

Summary

This PR adds full support for ExKoin cryptocurrency exchange to CCXT.

Implementation Details

  • ✅ All required public API methods implemented
  • ✅ All required private API methods implemented (including ledgers)
  • ✅ Comprehensive error handling
  • ✅ Full test coverage
  • ✅ All builds passing
  • ✅ Follows CCXT coding standards

Exchange Information

Supported Features

  • Spot trading
  • Market data (tickers, orderbook, trades, OHLCV)
  • Account management (balance, orders, trade history)
  • Order management (create, cancel, fetch)

Maintenance Commitment

I will actively maintain this implementation and provide ongoing support.

Ready for review and merge. 🚀
Thanks.

ps: i'm not sure if i was supposed to push the abstract file too, but i cannot build if its fully missing.

ts/src/exkoin.ts Outdated
}

_exkoin_safeTimestamp (item: Dict, key: IndexType): Int {
return this.safeInteger (item, key);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is not needed at all

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced directly with this.safeInteger
this.safeTimestamp does a x1000, however exkoin api return ms timestamps already.

ts/src/exkoin.ts Outdated
return this.safeInteger (item, key);
}

_parseLedger (data, since: Int = undefined, limit: Int = undefined, params = {}): LedgerEntry[] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parserMethods should follow the standard naming, in this case parseLedgerEntry and use the base parseLedger

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ts/src/exkoin.ts Outdated
Comment on lines 1095 to 1102

parseMyTrades (trades, market = undefined, since = undefined, limit = undefined): Trade[] {
const result = [];
for (let i = 0; i < trades.length; i++) {
const trade = this.parseMyTrade (trades[i], market);
result.push (trade);
}
return this.filterBySinceLimit (result, since, limit);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use parseTrades to parse several trades (both private and public) and then parseTrade() should parse both types (private trades and public trades)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0