-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add Exkoin exchange implementation #26276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ts/src/exkoin.ts
Outdated
} | ||
|
||
_exkoin_safeTimestamp (item: Dict, key: IndexType): Int { | ||
return this.safeInteger (item, key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is not needed at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced directly with this.safeInteger
this.safeTimestamp does a x1000, however exkoin api return ms timestamps already.
ts/src/exkoin.ts
Outdated
return this.safeInteger (item, key); | ||
} | ||
|
||
_parseLedger (data, since: Int = undefined, limit: Int = undefined, params = {}): LedgerEntry[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parserMethods should follow the standard naming, in this case parseLedgerEntry
and use the base parseLedger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
ts/src/exkoin.ts
Outdated
|
||
parseMyTrades (trades, market = undefined, since = undefined, limit = undefined): Trade[] { | ||
const result = []; | ||
for (let i = 0; i < trades.length; i++) { | ||
const trade = this.parseMyTrade (trades[i], market); | ||
result.push (trade); | ||
} | ||
return this.filterBySinceLimit (result, since, limit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use parseTrades to parse several trades (both private and public) and then parseTrade()
should parse both types (private trades and public trades)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Add ExKoin Exchange Support
Summary
This PR adds full support for ExKoin cryptocurrency exchange to CCXT.
Implementation Details
Exchange Information
Supported Features
Maintenance Commitment
I will actively maintain this implementation and provide ongoing support.
Ready for review and merge. 🚀
Thanks.
ps: i'm not sure if i was supposed to push the abstract file too, but i cannot build if its fully missing.